Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MUI Tab console warnings #984

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Feb 19, 2024

Part of: #960

Fixed
Screenshot 2024-02-20 at 12 57 00 AM

Fixed the disabled tab color

Screenshot 2024-02-20 at 11 33 51 AM

Screenshot 2024-02-20 at 11 34 02 AM

@debsmita1 debsmita1 requested a review from a team as a code owner February 19, 2024 19:30
Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 0f0023b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@debsmita1 debsmita1 requested review from christoph-jerolimov and removed request for davidfestal and PatAKnight February 19, 2024 19:30
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-984!

Copy link
Contributor

janus-idp bot commented Feb 19, 2024

backstage-showcase Tests on commit 8556911 finished successfully.
View test log

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

@debsmita1 jobs are failing for changeset it seems, you might need to add one

@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2024
@kadel
Copy link
Member

kadel commented Feb 20, 2024

/lgtm

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-984!

@debsmita1 debsmita1 changed the title Fix MUI Tab console warnings [WIP] Fix MUI Tab console warnings Feb 20, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-984!

@invincibleJai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [invincibleJai,kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debsmita1 debsmita1 changed the title [WIP] Fix MUI Tab console warnings Fix MUI Tab console warnings Feb 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit eaedce0 into redhat-developer:main Feb 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants