Skip to content

fix: failing ui tests #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djelinek merged 5 commits into from
Jul 2, 2025
Merged

fix: failing ui tests #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
708a964
chore(runner): bump devDeps of ui tests example project
djelinek Jul 2, 2025
0349655
chore(runner): remove unused changelog markdown file
djelinek Jul 2, 2025
51f5e7e
chore(runner): compile source files before each ui-test run
djelinek Jul 2, 2025
d46ea25
chore: update tsconfig to use 'only' warnings for unused locals and …
djelinek Jul 2, 2025
3a65dde
test(runner): resolve ui-test timing issues
djelinek Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/extester-runner/CHANGELOG.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/extester-runner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@
"lint": "eslint --fix --fix-type layout src",
"compile-tests": "tsc -p . --outDir out",
"test": "npm run compile && node ./out/test/runTest.js",
"ui-test": "extest setup-and-run ./out/ui-test/*.test.js --uninstall_extension --extensions_dir .test-extensions"
"ui-test": "npm run compile && extest setup-and-run ./out/ui-test/*.test.js --uninstall_extension --extensions_dir .test-extensions"
},
"devDependencies": {
"@types/babel__traverse": "^7.20.7",
Expand Down
1 change: 1 addition & 0 deletions packages/extester-runner/src/ui-test/01_extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ describe('ExTester Runner', function () {
*/
before(async function () {
driver = VSBrowser.instance.driver;
await driver.sleep(3_000); // give vscode workbench some time to load properly
await waitUntilExtensionIsActivated(driver, `${pjson.displayName}`);
});

Expand Down
22 changes: 12 additions & 10 deletions packages/extester-runner/src/ui-test/03_extersterTreeProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ describe('Parser test suite', function () {
this.timeout(30000);

const browser = VSBrowser.instance;
await browser.openResources(EXAMPLE_PROJECT);
await browser.openResources(EXAMPLE_PROJECT, async () => {
await browser.driver.sleep(3_000);
});

await updateSettings(TEST_FILE_GLOB_SETTINGS_ID, TEST_FILE_GLOB);
});
Expand All @@ -84,7 +86,7 @@ describe('Parser test suite', function () {
const runnerView = await (await new ActivityBar().getViewControl(EXTESTER_RUNNER))?.openView();
assert.ok(runnerView, 'Runner view not found');

const content = await runnerView.getContent();
const content = runnerView.getContent();
assert.ok(content, 'Content not found');

const sections = await content.getSections();
Expand Down Expand Up @@ -131,7 +133,7 @@ describe('Parser test suite', function () {
const runnerView = await (await new ActivityBar().getViewControl(EXTESTER_RUNNER))?.openView();
assert.ok(runnerView, 'Runner view not found');

const content = await runnerView.getContent();
const content = runnerView.getContent();
assert.ok(content, 'Content not found');

const sections = await content.getSections();
Expand Down Expand Up @@ -178,7 +180,7 @@ describe('Parser test suite', function () {
const runnerView = await (await new ActivityBar().getViewControl(EXTESTER_RUNNER))?.openView();
assert.ok(runnerView, 'Runner view not found');

const content = await runnerView.getContent();
const content = runnerView.getContent();
assert.ok(content, 'Content not found');

const sections = await content.getSections();
Expand Down Expand Up @@ -227,7 +229,7 @@ describe('Parser test suite', function () {
const runnerView = await (await new ActivityBar().getViewControl(EXTESTER_RUNNER))?.openView();
assert.ok(runnerView, 'Runner view not found');

const content = await runnerView.getContent();
const content = runnerView.getContent();
assert.ok(content, 'Content not found');

const sections = await content.getSections();
Expand Down Expand Up @@ -255,12 +257,12 @@ describe('Parser test suite', function () {
assert.strictEqual(firstDescribeLabel.trim(), EXPECTED_DESCRIBE_1);

// first describe first test
const firstDesribeIts = await firstDescribe.getChildren();
assert.ok(firstDesribeIts?.length === 1, 'First describe should have exactly one it');
const firstDescribeIts = await firstDescribe.getChildren();
assert.ok(firstDescribeIts?.length === 1, 'First describe should have exactly one it');

const firstDesribeFirstIt = firstDesribeIts[0];
const firstDesribeFirstItLabel = await firstDesribeFirstIt.getLabel();
assert.strictEqual(firstDesribeFirstItLabel.trim(), EXPECTED_TEST_1);
const firstDescribeFirstIt = firstDescribeIts[0];
const firstDescribeFirstItLabel = await firstDescribeFirstIt.getLabel();
assert.strictEqual(firstDescribeFirstItLabel.trim(), EXPECTED_TEST_1);

// second describe
const secondDescribe = describes[1];
Expand Down
Loading