Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against a null completion item resolved on cancellation. #3973

Merged

Conversation

rgrunber
Copy link
Member

If you activate completion, and use the arrow keys to quickly scroll through all the options, you eventually get :

2025-03-11 16:29:37.201 [error] [redhat.java] provider FAILED
2025-03-11 16:29:37.201 [error] TypeError: Cannot read properties of null (reading 'documentation')
	at /home/rgrunber/git/vscode-java/dist/extension.js:91685:48
	at Generator.next (<anonymous>)
	at fulfilled (/home/rgrunber/git/vscode-java/dist/extension.js:91445:58)
	at processTicksAndRejections (node:internal/process/task_queues:95:5)
	at runNextTicks (node:internal/process/task_queues:64:3)
	at process.processImmediate (node:internal/timers:454:9)
	at process.callbackTrampoline (node:internal/async_hooks:130:17)

It seems mostly harmless but does pollute the extension host logs so would be good to handle this.

  • A cancelled completion item resolve request returns as null

@rgrunber rgrunber added the bug label Mar 11, 2025
@rgrunber rgrunber added this to the End March 2025 milestone Mar 11, 2025
- A cancelled completion item resolve request returns as null

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber force-pushed the null-completion-on-cancel branch from ccc39f4 to 2f1eea7 Compare March 11, 2025 20:35
@rgrunber rgrunber self-assigned this Mar 11, 2025
@rgrunber rgrunber merged commit 6bba969 into redhat-developer:master Mar 12, 2025
2 checks passed
@rgrunber rgrunber deleted the null-completion-on-cancel branch March 12, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant