Skip to content

fix(auth): remove check restricting empty UID to handle kube:admin bootstrap user scenario #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkwon17 merged 2 commits into from
Jun 25, 2026
Merged

fix(auth): remove check restricting empty UID to handle kube:admin bootstrap user scenario #135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a005dee
fix(auth): allow empty UID for kube:admin bootstrap user
rohanKanojia Jun 25, 2026
923ece6
fix(auth): prefer OpenShift User API for UID lookup with SSR fallback
rohanKanojia Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions pkg/operations/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,8 @@ func getCurrentUserUIDFromSelfSubjectReview(token string, clientProvider ClientP
return "", err
}

if review.Status.UserInfo.UID == "" {
return "", fmt.Errorf("SelfSubjectReview returned empty UID")
}

// kube:admin / kubeadmin have no Kubernetes UID; empty string is a valid identifier
// when AUTHENTICATED_USER_ID is also empty (see config.AuthenticatedUserID).
return review.Status.UserInfo.UID, nil
}

Expand All @@ -166,10 +164,5 @@ func getCurrentUserUIDFromOpenShiftUserAPI(token string, clientProvider ClientPr
return "", err
}

uid := string(userInfo.GetUID())
if uid == "" {
return "", fmt.Errorf("OpenShift User API returned empty UID")
}

return uid, nil
return string(userInfo.GetUID()), nil
}
8 changes: 4 additions & 4 deletions pkg/operations/operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,20 @@ func TestGetCurrentUserUID(t *testing.T) {
errRegexp: "failed to get current user information",
},
{
name: "Should return error when SelfSubjectReview returns empty UID",
name: "Should allow empty UID from SelfSubjectReview for kube:admin",
provider: testUserIDClientProvider{
userUID: "",
},
errRegexp: "SelfSubjectReview returned empty UID",
expectedUID: "",
},
{
name: "Should return error when OpenShift User API returns empty UID",
name: "Should allow empty UID from OpenShift User API for kube:admin",
provider: testUserIDClientProvider{
returnReviewError: apierrors.NewNotFound(schema.GroupResource{Group: "authentication.k8s.io", Resource: "selfsubjectreviews"}, "self"),
userAPIUID: "",
emptyUserAPIUID: true,
},
errRegexp: "OpenShift User API returned empty UID",
expectedUID: "",
},
}

Expand Down
Loading