Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for auto completion with escape sequence chars #1040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

This PR suggest characters with escape chars if needed

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#1097

Is it tested? How?

Yes added test case for the fix

@coveralls
Copy link

Coverage Status

coverage: 84.075% (-0.06%) from 84.136%
when pulling d3cf06d on msivasubramaniaan:fix-unescaped-char-at-completion
into 11eff5f on redhat-developer:main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 84.075% (-0.06%) from 84.136%
when pulling d3cf06d on msivasubramaniaan:fix-unescaped-char-at-completion
into 11eff5f on redhat-developer:main.

@coveralls
Copy link

Coverage Status

coverage: 84.075% (-0.06%) from 84.136%
when pulling d3cf06d on msivasubramaniaan:fix-unescaped-char-at-completion
into 11eff5f on redhat-developer:main.

@datho7561
Copy link
Contributor

This doesn't fix issue for me. Make the following document, and open completion at the |:

# yaml-language-server: $schema=https://raw.githubusercontent.com/RedCMD/TmLanguage-Syntax-Highlighter/main/vscode.tmLanguage.schema.json
|

Accept the completion "New Grammar".

The generated content is still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants