Fix "convert tabs to space" quickfix for "indentation cannot be tabs" #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the error message changed when switching validators. There is nothing more concrete (such as a diagnostic code) to identify the "identation cannot be tabs" diagnostics. Fixes redhat-developer#1052 Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the error message that the code action provider expects so that the quickfix is generated once more.
I think the error message changed when switching validators. There is nothing more concrete (such as a diagnostic code) to identify the "indentation cannot be tabs" diagnostics.
What issues does this PR fix or reference?
Fixes #1052
Is it tested? How?
I've updated the unit tests. Perhaps an integration test would be helpful to avoid something similar happening in the future? I'd like a second opinion in this.