feat: add platform engineer user entity and developer group #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanshortiss
commented
Dec 17, 2024
| children: [] | ||
| --- | ||
| apiVersion: backstage.io/v1alpha1 | ||
| kind: Group |
Author
There was a problem hiding this comment.
This group makes it easier to assign RBAC permissions to all regular users1...n
evanshortiss
commented
Dec 17, 2024
| apiVersion: backstage.io/v1alpha1 | ||
| kind: User | ||
| metadata: | ||
| name: pe |
Author
There was a problem hiding this comment.
PE user will have admin privileges from RBAC plugin
evanshortiss
commented
Dec 17, 2024
| picture: https://avatars.dicebear.com/api/avataaars/breanna-davison@example.com.svg?background=%23fff | ||
| memberOf: [user{{ index + 1 }}] | ||
| picture: https://api.dicebear.com/9.x/thumbs/svg?seed={{ user_images[index % user_images | length] }} | ||
| memberOf: [user{{ index + 1 }}, developers] |
Author
There was a problem hiding this comment.
Question: should we remove the userN group entirely? Was there a reason it was added? Seems a little confusing to have a user and group with the same name 1:1.
evanshortiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
Enables a new platform engineer user to login. Linked PR redhat-gpte-devopsautomation/agnosticg#5
It also creates a
developersgroup foruser1..userN, and fixes the avatar URLs to use the newer format by dicebear.In theory we can avoid the need to hardcode these entities in the future, by using the GitLab Org plugin and structuring groups in GitLab appropriately. It will depend on this issue being resolved
How to test changes / Special notes to the reviewer
You can add this entity to the org.yaml on an existing RHDH demo cluster and create the user manually in GitLab using the following cURL command. You should be able to login to RHDH as the
peuser after completing both of these steps.curl --request POST \ --url "$GITLAB_HOST/api/v4/users" \ --header "PRIVATE-TOKEN: $GITLAB_TOKEN" \ --header "Content-Type: application/x-www-form-urlencoded" \ --data-urlencode "admin=false" \ --data-urlencode "email=pe@demo.com" \ --data-urlencode "public_email=pe@demo.com" \ --data-urlencode "skip_confirmation=true" \ --data-urlencode "username=pe" \ --data-urlencode "password=$PE_PASSWORD" \ --data-urlencode "name=Platform Engineer"