fix(ISV-7300): remove the need for authentication in test pipeline#478
Conversation
Signed-off-by: Marek Szymutko <mszymutk@redhat.com> Assisted-by: Claude-4.6-Opus (Cursor)
BorekZnovustvoritel
force-pushed
the
ISV-7300-upstream-prod
branch
from
75ba304 to
de27e6e
Compare
| - name: "Download and extract go binary to {{ testing_bin_path }}" | ||
| unarchive: | ||
| src: "https://storage.googleapis.com/golang/go{{ go_version }}.linux-amd64.tar.gz" | ||
| src: "https://dl.google.com/go/go{{ go_version }}.linux-amd64.tar.gz" |
There was a problem hiding this comment.
This URL changed (the original no longer works, the image was not buildable).
| --- | ||
| - name: "Pull the base image {{ container_tool }} pull --arch={{ mfbc_architecture }} {{ mirror_multiarch_image }}" | ||
| shell: "{{ container_tool }} pull --arch={{ mfbc_architecture }} {{ mirror_multiarch_image }}" | ||
| when: registry_redhat_io_user is defined and registry_redhat_io_token is defined |
There was a problem hiding this comment.
This condition did not make sense since the image is retagged in the next step unconditionally. If the user and/or token were not defined, this playbook just failed.
| # src: "{{ pfbc_local_cache_dir }}/" | ||
| # dest: "{{ pfbc_extracted_fbc_location }}/cache/" | ||
| - name: "Generate cache locally using host opm to solve arch issues" | ||
| shell: "{{ opm_bin_path }} serve {{ pfbc_fbc_config_path }} --cache-dir={{ pfbc_extracted_fbc_location }}/cache --cache-only --termination-log /dev/null" |
There was a problem hiding this comment.
I found out that the custom cache IS needed. It's because without it, the playbook would try to run opm from within the multuarch image. It passed for amd64, but other arches failed immediately because the opm binary was not runnable.
However the cache can be created without ever reaching out to registry.redhat.io, so the credential requirement can be removed from here.
| stdout_callback = ansible.builtin.default | ||
| result_format = yaml |
There was a problem hiding this comment.
These were missed previously. stdout_callback = yaml has been removed from Ansible and the image was not buildable without this change.
3 participants
Assisted-by: Claude-4.6-Opus (Cursor)