Fix connection leak on early SIGINT in multiqueue#9
Draft
shivanayak wants to merge 1 commit intoredhat-openstack:masterfrom
Draft
Fix connection leak on early SIGINT in multiqueue#9shivanayak wants to merge 1 commit intoredhat-openstack:masterfrom
shivanayak wants to merge 1 commit intoredhat-openstack:masterfrom
Conversation
Initialize my_ports to [] before registering the signal handler in gen_stl() to prevent a NameError that would skip c.disconnect(). Co-Authored-By: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
my_ports = []before registering the signal handler ingen_stl()to prevent aNameErrorthat would skipc.disconnect()and leak the TRex client connection when SIGINT arrives before port assignment.Test plan
multiqueue.py --action gen_trafficimmediately after launch and verify TRex client disconnects cleanlygen_trafficflow end-to-end to confirm no regressionCo-Authored-By: Claude noreply@anthropic.com