Skip to content

fix(RHIDP-15009): alter resource limit for locust worker and master pods#404

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
shashankkestwal:fix/locust-resource-update
Jun 25, 2026
Merged

fix(RHIDP-15009): alter resource limit for locust worker and master pods#404
openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
shashankkestwal:fix/locust-resource-update

Conversation

@shashankkestwal

Copy link
Copy Markdown
Collaborator

No description provided.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shashankkestwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@shashankkestwal

Copy link
Copy Markdown
Collaborator Author

test complex-rbac

@shashankkestwal

Copy link
Copy Markdown
Collaborator Author

/test complex-rbac

@shashankkestwal shashankkestwal marked this pull request as ready for review June 24, 2026 14:48
@openshift-ci openshift-ci Bot requested review from jhutar and pmacik June 24, 2026 14:48
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added configurable resource settings for the main pods and worker pods, including CPU, memory, and ephemeral storage requests and limits.
    • Added configuration for the metrics exporter image and pull policy.

Walkthrough

The config/locust-k8s-operator.values.yaml file replaces the config.loadGenerationPods structure with a new top-level locustPods section. The new section defines resources and worker sub-blocks with CPU, memory, and ephemeralStorage request/limit values, and moves metricsExporter image and pullPolicy under locustPods.

Changes

locust-k8s-operator values restructure

Layer / File(s) Summary
Restructure locustPods resource and metricsExporter config
config/locust-k8s-operator.values.yaml
Removes the config.loadGenerationPods resource/metricsExporter block and replaces it with a top-level locustPods section containing resources, worker, and metricsExporter sub-keys, including ephemeralStorage fields with separate values for pod and worker.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so relevance to the changeset cannot be assessed beyond its absence. Add a brief description of the Locust resource changes so reviewers can confirm the intent and scope.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating resource limits for Locust worker and master pods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/locust-k8s-operator.values.yaml`:
- Around line 39-41: The metricsExporter image is using a mutable tag, which
makes deployments non-reproducible. Update the metricsExporter configuration to
reference a pinned version or immutable digest instead of latest-2.x, and keep
the pullPolicy aligned with the chosen pinning strategy so
locust-k8s-operator.values.yaml produces consistent test deployments. Use the
metricsExporter block to locate and replace the current image reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: b3ffb2a8-a46b-4e9c-81b6-d7f051fab35e

📥 Commits

Reviewing files that changed from the base of the PR and between e03232f and 59da8bf.

📒 Files selected for processing (1)
  • config/locust-k8s-operator.values.yaml

Comment on lines +39 to +41
metricsExporter:
image: "quay.io/backstage-performance/locust_exporter:latest-2.x"
pullPolicy: Always

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Pin the metrics exporter image instead of using a mutable tag.

latest-2.x plus pullPolicy: Always can pull different image contents between runs. Pin a version or digest to keep test deployments reproducible and reduce supply-chain risk.

Proposed direction
   metricsExporter:
-    image: "quay.io/backstage-performance/locust_exporter:latest-2.x"
-    pullPolicy: Always
+    image: "quay.io/backstage-performance/locust_exporter@sha256:<validated-digest>"
+    pullPolicy: IfNotPresent
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/locust-k8s-operator.values.yaml` around lines 39 - 41, The
metricsExporter image is using a mutable tag, which makes deployments
non-reproducible. Update the metricsExporter configuration to reference a pinned
version or immutable digest instead of latest-2.x, and keep the pullPolicy
aligned with the chosen pinning strategy so locust-k8s-operator.values.yaml
produces consistent test deployments. Use the metricsExporter block to locate
and replace the current image reference.

@pmacik

pmacik commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 25, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 51a12ef into redhat-performance:main Jun 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants