fix(RHIDP-15009): alter resource limit for locust worker and master pods#404
Conversation
Signed-off-by: skestwal <skestwal@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashankkestwal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
|
test complex-rbac |
|
/test complex-rbac |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changeslocust-k8s-operator values restructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/locust-k8s-operator.values.yaml`:
- Around line 39-41: The metricsExporter image is using a mutable tag, which
makes deployments non-reproducible. Update the metricsExporter configuration to
reference a pinned version or immutable digest instead of latest-2.x, and keep
the pullPolicy aligned with the chosen pinning strategy so
locust-k8s-operator.values.yaml produces consistent test deployments. Use the
metricsExporter block to locate and replace the current image reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: b3ffb2a8-a46b-4e9c-81b6-d7f051fab35e
📒 Files selected for processing (1)
config/locust-k8s-operator.values.yaml
| metricsExporter: | ||
| image: "quay.io/backstage-performance/locust_exporter:latest-2.x" | ||
| pullPolicy: Always |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Pin the metrics exporter image instead of using a mutable tag.
latest-2.x plus pullPolicy: Always can pull different image contents between runs. Pin a version or digest to keep test deployments reproducible and reduce supply-chain risk.
Proposed direction
metricsExporter:
- image: "quay.io/backstage-performance/locust_exporter:latest-2.x"
- pullPolicy: Always
+ image: "quay.io/backstage-performance/locust_exporter@sha256:<validated-digest>"
+ pullPolicy: IfNotPresent🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@config/locust-k8s-operator.values.yaml` around lines 39 - 41, The
metricsExporter image is using a mutable tag, which makes deployments
non-reproducible. Update the metricsExporter configuration to reference a pinned
version or immutable digest instead of latest-2.x, and keep the pullPolicy
aligned with the chosen pinning strategy so locust-k8s-operator.values.yaml
produces consistent test deployments. Use the metricsExporter block to locate
and replace the current image reference.
|
/lgtm |
51a12ef
into
redhat-performance:main
No description provided.