Fix auto_hpl parser to accept both T/V and TV header formats#15
Merged
grdumas merged 2 commits intoJun 5, 2026
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
grdumas
requested changes
May 21, 2026
grdumas
left a comment
grdumas
left a comment
Collaborator
There was a problem hiding this comment.
The fix looks correct - would you be able to add a a new regression test in tests/test_autohol_timestamps.py to assert parse success against the expected header? This will help us catch error-inducing changes in the future.
Covers the autohpl-wrapper v2.2+ header change where T/V became TV.
grdumas
approved these changes
Jun 4, 2026
grdumas
left a comment
grdumas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since autohpl-wrapper v2.2, the --field_header in build_run_hpl.sh generates the header as TV,N,NB,P,Q,Time,Gflops (without a slash), but chronicler's _parse_hpl_csv only matches headers starting with T/V (with a slash). This causes all auto_hpl results from wrapper v2.2+ to fail with:
Auto HPL results require timestamps. No header line with T/V,N,NB,P,Q,Time,Gflops,Start_Date,End_Date was found.
Affected versions: autohpl-wrapper v2.2 through v2.5 (v2.0 and v2.1 used T/V)
Fix: Update the header check in autohpl_processor.py to accept both formats.