Fix speccpu2017 processor to find CSVs in nested result directories#22
Merged
grdumas merged 1 commit intoJun 14, 2026
Conversation
The speccpu2017-wrapper v2.6 produces archives where CSV results are nested inside results_speccpu_*/result/ rather than directly in result/. The processor only searched one level deep with glob(), causing all SPEC CPU 2017 results to be silently empty. Switch from glob() to rglob() so the processor discovers CSVs regardless of directory depth.
📝 WalkthroughWalkthroughThis PR modifies ChangesRecursive CSV Discovery in Nested Results
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speccpu2017-wrapperv2.6 produces archives where CSV results are nested insideresults_speccpu_*/result/rather than directly inresult/glob("*.csv"), causing all SPEC CPU 2017 results to be silently empty, an empty document was indexed to OpenSearch with no suite dataglob()torglob()so the processor discovers CSVs regardless of directory nesting depthArchive structure produced by wrapper v2.6
The processor searched
extracted_path/andextracted_path/result/but neverextracted_path/results_speccpu_*/result/.Test plan
test_speccpu2017_csv_in_nested_results_subdircovers the nested directory case with both intrate and fprate CSVsfixes speccpu2017_processor fails to find CSV results - incorrect directory search depth #21