RPOPC-1319: CoreMark: Extract benchmark version from CSV

[grdumas]

Summary

Extracts CoreMark benchmark version from CSV comments and stores it in test.version, while preserving wrapper version in test.wrapper_version.

Acceptance Criteria

• Extract CoreMark benchmark version from CSV comments (pattern: # Results version: v1.01)
• Store extracted version as instance variable for use in build_test_info()
• Override build_test_info() to return benchmark version as test.version
• Ensure test.wrapper_version remains the wrapper version
• Add tests verifying version extraction from CSV comments
• Handle case when version is not present in CSV (fallback to wrapper version)

Changes

• Add _benchmark_version instance variable to CoreMarkProcessor
• Reset _benchmark_version at start of parse_runs() to prevent stale state
• Extract version from CSV comments during parsing (regex: Results version:\s*(\S+))
• Override build_test_info() to return benchmark version with fallback to wrapper version
• Add 3 comprehensive tests for version extraction

Testing

• Unit tests added (3 tests):
  • Version present in CSV → extracted to test.version
  • Version missing → fallback to wrapper version
  • State reset between parses → no stale version
• Integration tests passing (all 281 tests pass)
• Verified with sample data (extracts v1.01 from sample_data/.../coremark_2026.05.02-20.30.48/)

Related

• Closes RPOPC-1319
• Closes CoreMark processor does not extract benchmark version #44
• Parent: RPOPC-1315

Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@grdumas, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 24 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 91e0fbc9-1f45-47a3-b712-bd179220660c

📥 Commits

Reviewing files that changed from the base of the PR and between 483bf2d and 51fdbff.

📒 Files selected for processing (2)

• src/chronicler/processors/coremark_processor.py
• tests/test_coremark_timestamps.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[grdumas]

PR Review: RPOPC-1319: CoreMark: Extract benchmark version from CSV

Summary

This PR successfully extends the version conflation fix to the CoreMark processor. It efficiently extracts the benchmark version from CSV comments and correctly implements the build_test_info() override pattern, matching the robust standard established in previous updates.

Critical Issues (MUST FIX)

None found.

Major Issues (SHOULD FIX)

None found.

Minor Issues (NICE TO HAVE)

None found.

Nitpicks (OPTIONAL)

None found.

Positive Notes

• Proactive State Management: Including self._benchmark_version = None at the top of parse_runs() from the outset shows excellent awareness of the state leakage risk identified in earlier PRs.
• Clean Extraction: Pulling the version during a pre-parsing step (_extract_benchmark_version_from_csv) rather than mixing it with the heavy time-series parsing logic keeps the code very clean and readable.
• Robust Testing: The three new tests are excellent, specifically test_coremark_resets_benchmark_version_between_parses which explicitly validates the state management behavior.

Overall Assessment

• Status: APPROVE
• Reasoning: The implementation is clean, follows established patterns flawlessly, prevents state leakage, and is thoroughly covered by tests. All 281 tests pass successfully.
• Next Steps: Ready to merge.

---

Reviewed by: Gemini Pro via automated code review

[grdumas]

LGTM