Add tenant skip policy alert#919
Merged
ebattat merged 1 commit intoJun 29, 2025
Merged
Conversation
ebattat
force-pushed
the
tenant_skip_policy_alert
branch
from
e254923 to
a483b1e
Compare
Member
Author
|
ptal @halbfin 👋 |
Contributor
|
@ebattat Can you add |
ebattat
force-pushed
the
tenant_skip_policy_alert
branch
from
a483b1e to
754d526
Compare
ebattat
commented
Jun 23, 2025
| EnvironmentVariables.get_env('POLICIES_TO_ALERT', '[]')) | ||
| self._environment_variables_dict['ADMIN_MAIL_LIST'] = EnvironmentVariables.get_env('ADMIN_MAIL_LIST', '') | ||
| self._environment_variables_dict['SKIP_POLICIES_ALERT'] = literal_eval( | ||
| EnvironmentVariables.get_env('SKIP_POLICIES_ALERT', "['']")) |
ebattat
force-pushed
the
tenant_skip_policy_alert
branch
from
754d526 to
34c3ea0
Compare
ebattat
commented
Jun 23, 2025
| // By default, all policies are running in dry_run="yes" mode and the whole list can be found in run_policies.py | ||
| // POLICIES_IN_ACTION: Policies that run in the dry_run="no" mode | ||
| POLICIES_IN_ACTION = '["unattached_volume", "ip_unattached", "zombie_snapshots", "unused_nat_gateway", "s3_inactive", "empty_roles", "zombie_cluster_resource"]' | ||
| SKIP_POLICIES_ALERT = '["unused_access_key"]' |
Member
Author
There was a problem hiding this comment.
@athiruma,
I moved POLICIES_IN_ACTION and SKIP_POLICIES_ALERT to environment section in ecoeng_01, ecoeng_02 and ecoeng_03.
can you pls review it ?
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Add tenant skip policy alert to avoid sending email alerts for every policy, reducing the volume of alert emails
For security reasons, all pull requests need to be approved first before running any automated CI