Skip to content

Tagging Azure resources#925

Closed
ebattat wants to merge 1 commit into
redhat-performance:mainfrom
ebattat:add_azure_tagging
Closed

Tagging Azure resources#925
ebattat wants to merge 1 commit into
redhat-performance:mainfrom
ebattat:add_azure_tagging

Conversation

@ebattat

@ebattat ebattat commented Jul 9, 2025

Copy link
Copy Markdown
Member

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Tagging Azure resources according to their resource groups.
It loops over each resource group and tags all resources related to it.

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat requested review from athiruma and inntran July 9, 2025 12:23
@ebattat ebattat self-assigned this Jul 9, 2025
@ebattat ebattat added enhancement New feature or request ok-to-test PR ok to test labels Jul 9, 2025
@ebattat ebattat force-pushed the add_azure_tagging branch from 643610a to 6ff95ad Compare July 9, 2025 12:41

@inntran inntran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this new feature?

self._environment_variables_dict['account'] = EnvironmentVariables.get_env('account', '').upper().strip()
self._environment_variables_dict['AWS_DEFAULT_REGION'] = EnvironmentVariables.get_env('AWS_DEFAULT_REGION', '')
self._environment_variables_dict['log_level'] = EnvironmentVariables.get_env('log_level', 'INFO')
self._environment_variables_dict['GLOBAL_TAGS'] = literal_eval(EnvironmentVariables.get_env('GLOBAL_TAGS', "{}"))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this GLOBAL_TAGS?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @inntran,

app-code: 
service-phase: 
cost-center: 

@ebattat

ebattat commented Jul 16, 2025

Copy link
Copy Markdown
Member Author

Due to integration test failure open new pr

@ebattat ebattat closed this Jul 16, 2025
@github-project-automation github-project-automation Bot moved this from In progress to Done in Cloud-Governance project Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ok-to-test PR ok to test

Projects

Development

Successfully merging this pull request may close these issues.

2 participants