Skip to content

Update cluster_prefix from string to list #927

Merged
ebattat merged 1 commit into
redhat-performance:mainfrom
ebattat:fix_cluster_prefix
Jul 16, 2025
Merged

Update cluster_prefix from string to list #927
ebattat merged 1 commit into
redhat-performance:mainfrom
ebattat:fix_cluster_prefix

Conversation

@ebattat

@ebattat ebattat commented Jul 13, 2025

Copy link
Copy Markdown
Member

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Update cluster_prefix from string to list in test because it causing incorrect cluster filtering vpc deletion
  2. Update cluster tagging using cluster_prefix list instead of string
    cluster_prefix=["kubernetes.io/cluster", "sigs.k8s.io/cluster-api-provider-aws/cluster"]

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat requested a review from athiruma July 13, 2025 13:04
@ebattat ebattat self-assigned this Jul 13, 2025
@ebattat ebattat added bug Something isn't working ok-to-test PR ok to test labels Jul 13, 2025
@ebattat ebattat mentioned this pull request Jul 13, 2025
4 tasks
@ebattat ebattat force-pushed the fix_cluster_prefix branch 2 times, most recently from 4c445ef to 63869f0 Compare July 13, 2025 15:14
@ebattat ebattat force-pushed the fix_cluster_prefix branch from 63869f0 to 0efaf49 Compare July 14, 2025 08:22

@athiruma athiruma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ebattat ebattat merged commit 74a38b3 into redhat-performance:main Jul 16, 2025
18 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Cloud-Governance project Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ok-to-test PR ok to test

Projects

Development

Successfully merging this pull request may close these issues.

2 participants