Skip to content

'tag_cluster' policy applying kubernetes.io/cluster/<name>=owned to Hypershift SG’s#976

Merged
pragya811 merged 6 commits into
mainfrom
cluster-tag-fix
Mar 25, 2026
Merged

'tag_cluster' policy applying kubernetes.io/cluster/<name>=owned to Hypershift SG’s#976
pragya811 merged 6 commits into
mainfrom
cluster-tag-fix

Conversation

@pragya811

Copy link
Copy Markdown
Member

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

The ‘tag_cluster’ policy added kubernetes.io/cluster/ = owned to all security groups in a cluster. In Hypershift only the load balancer SG should have this tag; adding it to node/control-plane SGs broke cluster behavior.

Added a filtering so the policy excludes applying the cluster prefixes in the tagging.

For security reasons, all pull requests need to be approved first before running any automated CI

@pragya811 pragya811 self-assigned this Mar 12, 2026
Comment thread cloud_governance/policy/policy_operations/aws/tag_cluster/tag_cluster_resouces.py Outdated
Comment thread cloud_governance/main/environment_variables.py Outdated
Comment thread cloud_governance/main/environment_variables.py

@ebattat ebattat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check if we can add any test to cover this scenario before merging

@ebattat ebattat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@pragya811 pragya811 merged commit 908bbb1 into main Mar 25, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Cloud-Governance project Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants