Fix ElasticSearch UnsupportedProductError

[pragya811]

Type of change

Note: Fill x in []

• bug
• enhancement
• documentation
• dependencies

Description

The elasticsearch-py 7.14+ client introduced a product verification check that rejects connections to non-Elasticsearch servers. Since we connect to OpenSearch 1.2.4, the client throws UnsupportedProductError on the first request (ping()), preventing all data uploads.

Fix : Bypass the product verification by setting transport._verified_elasticsearch = True immediately after client initialization, before any requests are made. This skips the server product check while preserving all existing client functionality.

For security reasons, all pull requests need to be approved first before running any automated CI

Summary by CodeRabbit

• Bug Fixes
  • Improved Elasticsearch/OpenSearch client compatibility.
  • Added graceful handling during client initialization; emits a warning when certain client verification details are unavailable to avoid failures.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 232625b7-e28a-40db-876e-b1d7be8d04b5

📥 Commits

Reviewing files that changed from the base of the PR and between 66857ba and 2ed77cc.

📒 Files selected for processing (1)

• cloud_governance/common/elasticsearch/elasticsearch_operations.py

🚧 Files skipped from review as they are similar to previous changes (1)

• cloud_governance/common/elasticsearch/elasticsearch_operations.py

---

📝 Walkthrough

Walkthrough

Elasticsearch client initialization in ElasticSearchOperations.__init__ now attempts to set the transport's internal _verified_elasticsearch flag to True after client creation, with an AttributeError caught and logged; no public signatures changed.

Changes

Elasticsearch Client Initialization

Layer / File(s)	Summary
Client Construction cloud_governance/common/elasticsearch/elasticsearch_operations.py	Existing code constructs the Elasticsearch client and assigns it to self.__es.
Post-init Transport Patch cloud_governance/common/elasticsearch/elasticsearch_operations.py	After construction, code tries to set self.__es.transport._verified_elasticsearch = True when the attribute exists to bypass product verification.
Error Handling / Logging cloud_governance/common/elasticsearch/elasticsearch_operations.py	The assignment is wrapped in try/except AttributeError and logs a warning if the attribute is absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisker-quick tweak, one boolean true,
I hopped in the code and made the wires new.
No signatures harmed, just a gentle cheer,
Elasticsearch and friends now draw near. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: fixing an ElasticSearch UnsupportedProductError that occurs when connecting to OpenSearch. It accurately reflects the bug being resolved.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch es_error

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cloud_governance/common/elasticsearch/elasticsearch_operations.py`:
- Around line 57-58: The code unconditionally writes to the private field
self.__es.transport._verified_elasticsearch which can be absent in other
elasticsearch-py versions and currently lives inside a broad except that sets
self.__es = None; instead, guard that write by checking hasattr(self, "__es")
and hasattr(self.__es, "transport") and hasattr(self.__es.transport,
"_verified_elasticsearch") (or wrap only that assignment in a try/except
AttributeError), and on failure log a warning with the exception details (do not
set self.__es = None there). Narrow the broad exception handling around client
creation/connection so only real connection/creation failures set self.__es =
None, and keep the private-attribute override isolated and safely handled in the
method where self.__es is initialized/modified.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 430bd23a-1e74-4700-b011-8495625b8eda

📥 Commits

Reviewing files that changed from the base of the PR and between b25434c and 66857ba.

📒 Files selected for processing (1)

• cloud_governance/common/elasticsearch/elasticsearch_operations.py

[ebattat]

@pragya811, I will aproved it but we should ask @inntran to upgrade OpenSearch version to support elasticsearch 8/9 versions.

[ebattat]

/approved