Move ecoeng accounts from ecoeng01 to ecoeng03#998
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe ecoeng_03 daily Jenkins policy pipeline and documentation are updated to support additional AWS accounts and modify policy execution behavior. The ChangesAccount and Policy Configuration for ecoeng_03
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jenkins/tenant/aws/ecoeng_03/README.md`:
- Around line 7-10: The README's coreos-training admin list is missing
mrhillsman@redhat.com compared to the effective configuration in
PolicyJenkinsfileDaily (accounts_list); update the coreos-training entry in
README.md to include "mrhillsman@redhat.com" so the admin list matches the
accounts_list defined in PolicyJenkinsfileDaily.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 86ed990b-752c-4e01-99a1-237d1bbe9afe
📒 Files selected for processing (4)
jenkins/tenant/aws/ecoeng_01/TaggingJenkinsfileHourlyjenkins/tenant/aws/ecoeng_03/PolicyJenkinsfileDailyjenkins/tenant/aws/ecoeng_03/README.mdjenkins/tenant/aws/ecoeng_03/TaggingJenkinsfileHourly
ebattat
left a comment
ebattat
left a comment
There was a problem hiding this comment.
@pragya811, something weird in this PR, there are 15 old commits.
Pls close and open a new PR.
In addition, you need just move 3 accounts from 01 to 03, why did u enable
POLICIES_IN_ACTION = '["unused_access_key"]'
Move coreos-training, partnerlab, and certification-pipeline from ecoeng_01 to ecoeng_03 for both daily policies and hourly tagging. These accounts have CAPA/Hypershift deployments incompatible with zombie_cluster_resource detection, so they run with dry_run=yes. Update ecoeng_03 README to reflect actual configuration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@ebattat , fixed the commits issue. |
ebattat
left a comment
ebattat
left a comment
There was a problem hiding this comment.
@pragya811, Why are we moving the tagging from 01 to 03 ?
github-project-automation
Bot
moved this from In progress
to Done
in Cloud-Governance project
3 participants
Type of change
Note: Fill x in []
Description
Move coreos-training, partnerlab, and certification-pipeline accounts from ecoeng_01 to ecoeng_03 so all their policies (including zombie_cluster_resource) run with dry_run=yes.
Changes
ecoeng_01/TaggingJenkinsfileHourly -- Removed partnerlab and certification-pipeline from the account list (tagging now handled by ecoeng_03).
ecoeng_03/TaggingJenkinsfileHourly -- Added partnerlab and certification-pipeline alongside existing coreos-training.
ecoeng_03/PolicyJenkinsfileDaily -- Added certification-pipeline, partnerlab, and coreos-training to the accounts list with their original admin email lists.
ecoeng_03/README.md -- Updated to reflect actual POLICIES_IN_ACTION.
For security reasons, all pull requests need to be approved first before running any automated CI
Summary by CodeRabbit