Adding test results validation by regexp#26
Closed
dvalinrh wants to merge 6 commits into
Closed
Conversation
|
This relates to RPOPC-348 |
dvalinrh
force-pushed
the
test_validation
branch
from
1c48e81 to
d87bf6e
Compare
kdvalin
requested changes
Aug 12, 2025
| # Multiple lines may be present. | ||
| # | ||
| %_multiples | ||
| :[1-9][0-9]{0,}:[1-9][0-9]{0,}:GFlops:[1-9][0-9\.]{0,}:[0-9,]{1,}$ |
Contributor
Author
|
Switching to use pythion and json instead of regexp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the required files and hooks into the wrapper for verification of the test results via regexp.
This adds the required files and hooks into the wrapper for verification of the test results via regexp.
Mapping results to regexp
Typical results
ht_config:sockets:threads:unit:MB/sec:cpu_affin
ht_yes_1_socket:1:2:GFlops:132:0,1
ht_yes_1_socket:1:2:GFlops:132:2,3,0,1
Regexp file contents
%_header
ht_config:sockets:threads:unit:MB/sec:cpu_affin
%_multiples
:[[:digit:]]{1,}:[[:digit:]]{1,}:GFlops:[1-9][0-9]{0,}:[ 0-9,]{1,}$
%_header: Indicates the next line is a header that we need to match.
Field 1: Matches anything
Field 2: Expects a numerical value
Field 3: Expects a numerical value
Field 4: Expects GFLOPs
Field 5: Expects a non zero numerical value
Field 6: Expects numerical values, with commas.
Before/After Comparison
Before change: Failures will occur on validation
After change: Passes when it should, fails when it should.
Clerical Stuff
This closes #22
Relates to JIRA: RPOPC-348
Testing
Running the wrapper (modifying the regexps to force failures)
Verified test fails when it has bad data
Verified test passes when we have good data.