Skip to content

Verify run results via pyantic.#33

Merged
dvalinrh merged 1 commit into
mainfrom
verify_data
Feb 10, 2026
Merged

Verify run results via pyantic.#33
dvalinrh merged 1 commit into
mainfrom
verify_data

Conversation

@dvalinrh

@dvalinrh dvalinrh commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Description

  1. Verifies the run results using pyantics
  2. Fixes how test_tools is created
  3. Adds missing date stamps to csv file
  4. Renames results.csv to be results_linpack.csv

Before/After Comparison

Before: Results are not verified
After: Results are verified

Clerical Stuff

This closes #32

Relates to JIRA: RPOPC-820

Testing
Command executed
/home/ec2-user/workloads/linpack-wrapper/linpack/linpack_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m5.xlarge" --sysname "m5.xlarge" --sys_type aws --use_pcp --interleave all --iterations 1

successful
csv output
ht_config,sockets,threads,unit,MB_per_sec,cpu_affin,Start_Date,End_Date
ht_yes_1_socket,1,2,GFlops,132,0.1,2026-02-06T11:23:04Z,2026-02-06T11:23:57Z
ht_yes_1_socket,1,2,GFlops,132,2.3.0.1,2026-02-06T11:23:04Z,2026-02-06T11:23:57Z

echo $?: 0

Induced error
Could not verify schema, see below for details
2 validation errors for list[Linpack_Results]
0.MB_per_sec
Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='avg', input_type=str]
For further information visit https://errors.pydantic.dev/2.12/v/int_parsing
1.MB_per_sec
Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='avg', input_type=str]
For further information visit https://errors.pydantic.dev/2.12/v/int_parsing
updating: results_linpack_virtual-guest.tar (deflated 88%)
[root@ip-170-0-27-132 ec2-user]# echo $?
1

rtc: 0

@dvalinrh dvalinrh requested a review from kdvalin February 6, 2026 11:31
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown

This relates to RPOPC-820

Comment thread linpack/results_schema.py
Comment thread linpack/results_schema.py
@dvalinrh dvalinrh requested a review from kdvalin February 6, 2026 17:45

@kdvalin kdvalin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvalinrh dvalinrh merged commit 65b2d8c into main Feb 10, 2026
7 of 8 checks passed
@dvalinrh dvalinrh deleted the verify_data branch March 27, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use pyantics to verify run results

2 participants