Skip to content

Update error codes to be more specific.#35

Merged
dvalinrh merged 7 commits into
mainfrom
rerun
Mar 18, 2026
Merged

Update error codes to be more specific.#35
dvalinrh merged 7 commits into
mainfrom
rerun

Conversation

@dvalinrh

@dvalinrh dvalinrh commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Description

Updates error codes to be more specific
Now uses the package_tool
New method of getting test tools

Before/After Comparison

Before: Returned a 0 or 1, making determination of having to rerun very course. Also before packaging fix, linpack would fail. This is recent as the last of the packaging has been pulled.
After: Error codes are now bases on test_tools/error_codes, making it easier to limit when we do a rerun of the test.
Also, changed how we load in test_tools, we try curl, git, and wget, to avoid a failure due to the program not
being installed.

Clerical Stuff

This closes #34

Relates to JIRA: RPOPC-874

Testing
Ran the following scenario

global:
ssh_key_file: replace_your_ssh_key
terminate_cloud: 1
os_vendor: rhel
results_prefix: linpack_res
os_vendor: rhel
system_type: aws
cloud_os_id: ami-035032ea878eca201
systems:
system1:
tests: "linpack"
host_config: "m5.xlarge"

csv file
ht_config,sockets,threads,unit,MB_per_sec,cpu_affin,Start_Date,End_Date
ht_yes_1_socket,1,2,GFlops,133,0.1,2026-03-13T16:34:12Z,2026-03-13T16:35:04Z
ht_yes_1_socket,1,2,GFlops,133,2.3.0.1,2026-03-13T16:34:12Z,2026-03-13T16:35:04Z

Returned 0 as expected. Testing on rerun verification handled in the appropriate zathras pr.

@dvalinrh dvalinrh requested a review from malucius-rh March 13, 2026 17:55
@github-actions

Copy link
Copy Markdown

This relates to RPOPC-873

@github-actions

Copy link
Copy Markdown

This relates to RPOPC-874

@malucius-rh malucius-rh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra "1" laying around, I think

Comment thread linpack/linpack_extra/run_linpack.sh Outdated
@dvalinrh dvalinrh requested a review from malucius-rh March 13, 2026 18:09

@malucius-rh malucius-rh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvalinrh dvalinrh merged commit 5f41658 into main Mar 18, 2026
2 checks passed
@dvalinrh dvalinrh deleted the rerun branch March 27, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to be more specfic on error codes

2 participants