Add --benchmarks flag to limit what benchmarks pyperformance runs#55
Merged
Conversation
|
This relates to RPOPC-756 |
frival
reviewed
Jan 6, 2026
frival
left a comment
frival
left a comment
There was a problem hiding this comment.
Query on how we handle the benchmark list - right now it's not sanitized which might not be what we want to do.
When running using `--pyperf_benchmarks`, it will now check against `pyperformance list` to ensure that an invalid benchmark was not provided. Current behaviour is to exit when at least 1 benchmark is not valid, but the script will output all invalid benchmarks.
frival
approved these changes
Jan 15, 2026
frival
left a comment
frival
left a comment
There was a problem hiding this comment.
LGTM, thank you for not forcing innocent souls to read a python dump to figure out a typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--benchmarksflag which takes a comma separated list of pyperformance benchmark names. This flag will only run the specified benchmarks.The previous behavior of running all the benchmarks is the default, so any existing automation should not be impacted
Before/After Comparison
Before
The only behavior of this wrapper is to run all the pyperformance benchmarks.
After
The default behavior of this wrapper is to run all the pyperformance benchmarks.
The user can use
--benchmarks <name1,name2,...>to provide a list of benchmarks that they wish to run. This is useful for development and for skipping benchmarks that may have a longer runtime.Clerical Stuff
This closes #54
Relates to JIRA: RPOPC-756