fix: Update BlockingTransportFactory::create calls for 3-arg signature#118
Merged
Conversation
|
PR #116 added a send_delay parameter to BlockingTransportFactory::create but did not update the callers in standalone_server.rs and standalone_client.rs (introduced by PR #110). This caused compilation failures on main after both PRs merged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dustinblack
force-pushed
the
fix/factory-create-args
branch
from
fa9fbd9 to
da9f8c2
Compare
… rustup - Add missing send_delay parameter to all BlockingTransportFactory::create callers in standalone_server.rs and standalone_client.rs. PR #116 changed the signature to 3 arguments but did not update callers from PR #110, breaking compilation on main. - Switch MSRV pre-commit check from container (podman/docker) to rustup. The container approach failed in environments without container privileges, causing contributors to bypass pre-commit hooks entirely. The rustup approach reads the MSRV from Cargo.toml and works in any standard Rust development environment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dustinblack
force-pushed
the
fix/factory-create-args
branch
from
fab5bb5 to
48efe05
Compare
Add project guidelines for AI-assisted development covering MSRV, measurement accuracy, pre-commit hooks, testing, and commit standards. Optimize pre-commit hook to skip expensive checks (tests, audit, MSRV) when only Cargo.toml, Cargo.lock, or non-code files change. Fast checks (cargo check, clippy, fmt) still run for all Rust-related changes. AI-Assisted-By: Claude Opus 4.6 (1M context)
Collaborator
Author
|
Non-functional changes only. Pushing through without review. |
📈 Changed lines coverage: 100.00% (9/9)✅ All new and modified lines are covered by tests!📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockingTransportFactory::createto require asend_delayparameter without updating callers in the standalone modules from PR feat(cli): Add standalone --server and --client modes #110Test plan
cargo checkcompiles cleanly