Skip to content

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Mar 4, 2025

athierry1 and others added 2 commits March 4, 2025 18:18
When calling dracut with '--hostonly-mode=strict', get_dev_module() gets
called on the system's block devices to find the required drivers. The
driver name is retrieved using udevadm. However, the driver name
returned by udevadm is not necessarily the same as the module name.
This is the case for the Qualcomm UFS driver: udevadm returns
'ufshcd-qcom' while the module name is 'ufs-qcom', so dracut-install is
not able to find the module afterwards.

To solve this, make get_dev_module() also return the module alias info
from the modalias files contained in the sysfs directories parsed by
udevadm.

Signed-off-by: Adrien Thierry <[email protected]>

(cherry picked from commit 87a76db)

Resolves: RHEL-79790
In some x86_64 platforms such as Intel Elkhartlake, an issue of missing
necessary modules due to udevadm drivers field unmatch the real kernel module
name is found:

  $ udevadm info -a /dev/block/179:1

  looking at parent device '/devices/pci0000:00/0000:00:1a.0/mmc_host/mmc0/mmc0:0001':
    KERNELS=="mmc0:0001"
    SUBSYSTEMS=="mmc"
    DRIVERS=="mmcblk"
    ....

The DRIVERS field, aka mmcblk will be given to instmods to install the
corresponding mmc_block.ko kernel module. However mmc_block.ko cannot be
selected by string mmcblk, as a result, mmc_block.ko cannot be installed
in hostonly-mode strict, which will fail to bootup the machine such as in
kdump cases:

  $ /usr/lib/dracut/dracut-install -D /var/tmp --kerneldir /lib/modules/$(uname -r)/ -m mmcblk
  dracut-install: Failed to find module 'mmcblk'

In this patch, we will convert the string mmcblk to mmc_block, so the
kernel module can be successfully loaded.

Signed-off-by: Tao Liu <[email protected]>

(cherry picked from commit a62e895)

Resolves: RHEL-79790
@packit-as-a-service

This comment was marked as outdated.

@redhat-plumbers redhat-plumbers deleted a comment from packit-as-a-service bot Mar 4, 2025
@redhat-plumbers redhat-plumbers deleted a comment from packit-as-a-service bot Mar 4, 2025
This commit fixes the configuration for the forthcoming Packit 1.0.0.
See [our blog post](https://packit.dev/posts/packit_1_0_0_action_required) for more details.
  - Job type `build` has been changed to `copr_build`.
  - Job type `production_build` has been changed to `upstream_koji_build`.
  - Key `upstream_project_name` has been changed to `upstream_package_name`.
  - Key `synced_files` has been changed to `files_to_sync`.

Please review and merge me before January 2025 otherwise packit-service jobs will fail because of an invalid configuration.

Related: RHEL-79790
@pvalena pvalena force-pushed the rhel-9.5-fix-79790 branch from 924fb96 to 275a003 Compare March 4, 2025 17:24
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Commit validation

Tracker - Missing issue tracker ✋

The following commits meet all requirements

commit upstream
965c357 - fix(kernel-modules): use modalias info in get_dev_module() dracutdevs/dracut@87a76db
13f337e - fix(dracut-functions.sh): convert mmcblk to the real kernel module nam… dracutdevs/dracut@a62e895

The following commits need an inspection

commit note
275a003 - fix: update configuration for Packit 1.0.0 Missing upstream reference ‼️
5117fb7 - ci: bump actions/upload-artifact version to v4 Missing issue tracker

Tracker validation

🔴 Missing tracker or Unknown tracker type; type: 'unknown'


Pull Request validation

Failed

🔴 Failed or pending checks - testing-farm:centos-stream-9-x86_64[failure]
🔴 Review - Missing review from a member (1 required)

@pvalena pvalena merged commit 4d1b5ee into redhat-plumbers:rhel-9.5 Mar 12, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants