-
Notifications
You must be signed in to change notification settings - Fork 11
Rhel 9.5 fix 79790 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rhel 9.5 fix 79790 #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling dracut with '--hostonly-mode=strict', get_dev_module() gets called on the system's block devices to find the required drivers. The driver name is retrieved using udevadm. However, the driver name returned by udevadm is not necessarily the same as the module name. This is the case for the Qualcomm UFS driver: udevadm returns 'ufshcd-qcom' while the module name is 'ufs-qcom', so dracut-install is not able to find the module afterwards. To solve this, make get_dev_module() also return the module alias info from the modalias files contained in the sysfs directories parsed by udevadm. Signed-off-by: Adrien Thierry <[email protected]> (cherry picked from commit 87a76db) Resolves: RHEL-79790
In some x86_64 platforms such as Intel Elkhartlake, an issue of missing
necessary modules due to udevadm drivers field unmatch the real kernel module
name is found:
$ udevadm info -a /dev/block/179:1
looking at parent device '/devices/pci0000:00/0000:00:1a.0/mmc_host/mmc0/mmc0:0001':
KERNELS=="mmc0:0001"
SUBSYSTEMS=="mmc"
DRIVERS=="mmcblk"
....
The DRIVERS field, aka mmcblk will be given to instmods to install the
corresponding mmc_block.ko kernel module. However mmc_block.ko cannot be
selected by string mmcblk, as a result, mmc_block.ko cannot be installed
in hostonly-mode strict, which will fail to bootup the machine such as in
kdump cases:
$ /usr/lib/dracut/dracut-install -D /var/tmp --kerneldir /lib/modules/$(uname -r)/ -m mmcblk
dracut-install: Failed to find module 'mmcblk'
In this patch, we will convert the string mmcblk to mmc_block, so the
kernel module can be successfully loaded.
Signed-off-by: Tao Liu <[email protected]>
(cherry picked from commit a62e895)
Resolves: RHEL-79790
This comment was marked as outdated.
This comment was marked as outdated.
This commit fixes the configuration for the forthcoming Packit 1.0.0. See [our blog post](https://packit.dev/posts/packit_1_0_0_action_required) for more details. - Job type `build` has been changed to `copr_build`. - Job type `production_build` has been changed to `upstream_koji_build`. - Key `upstream_project_name` has been changed to `upstream_package_name`. - Key `synced_files` has been changed to `files_to_sync`. Please review and merge me before January 2025 otherwise packit-service jobs will fail because of an invalid configuration. Related: RHEL-79790
924fb96 to
275a003
Compare
Commit validationTracker - Missing issue tracker ✋ The following commits meet all requirements
The following commits need an inspection
Tracker validation🔴 Missing tracker or Unknown tracker type; type: 'unknown' Pull Request validationFailed🔴 Failed or pending checks - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHEL-79790