Skip to content

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Aug 8, 2025

  • refactor(dracut): introduce clamp_mtimes helper function
  • fix(dracut): ensure hardlink deduplication is reproducible

Avoid code duplication by introducing `clamp_mtimes`.

(cherry picked from commit b1f5842b36182d556f76d1bf9a023c74800b0880)

Related: RHEL-101901
By default, hardlink will only deduplicate files with identical mtimes,
down to one-second granularity. If a dracut module rapidly generates
multiple identical files, it is completely up to chance as to whether
their mtimes cross a second boundary or not, and thus whether they get
deduplicated or not. This results in non-reproducible output.

Re-order hardlink with respect to clamping to avoid this problem.

Fixes: https://issues.redhat.com/browse/RHEL-101901
(cherry picked from commit f779e439ec60eafcb400501d4741c755a95fdc86)

Resolves: RHEL-101901
@pvalena pvalena self-assigned this Aug 8, 2025
@github-actions github-actions bot changed the title rhel 9 fix 101901 (RHEL-101901) rhel 9 fix 101901 Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Commit validation

Tracker - RHEL-101901

The following commits need an inspection

commit note
80bf663 - refactor(dracut): introduce clamp_mtimes helper function Missing upstream reference ‼️
12a9745 - fix(dracut): ensure hardlink deduplication is reproducible Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-101901 has set desired product: rhel-9.7
🟢 Tracker RHEL-101901 has set desired component: dracut
🟢 Tracker RHEL-101901 has been approved
🟢 Tracker RHEL-101901 has set severity


Pull Request validation

Failed

🔴 Failed or pending checks:

  • test (centos:stream9, 30)[failure]
  • test (centos:stream9, 15)[failure]
  • test (centos:stream9, 14)[failure]
  • test (centos:stream9, 03)[failure]
  • test (centos:stream9, 36)[failure]
  • test (centos:stream9, 35)[failure]
  • test (centos:stream9, 31)[failure]
  • test (centos:stream9, 13)[cancelled]
  • test (centos:stream9, 98)[cancelled]
  • test (centos:stream9, 02)[cancelled]
  • centos-9-stream (centos:stream9, 16)[cancelled]
  • centos-9-stream (centos:stream9, 12)[cancelled]
  • centos-9-stream (centos:stream9, 20)[cancelled]
  • centos-9-stream (centos:stream9, 11)[cancelled]
  • centos-9-stream (centos:stream9, 41)[cancelled]
  • centos-9-stream (centos:stream9, 17)[cancelled]
  • centos-9-stream (centos:stream9, 40)[cancelled]
  • centos-9-stream (centos:stream9, 21)[cancelled]
  • basic (centos:stream9, 04)[failure]
  • testing-farm:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-aarch64[in_progress]
  • rpm-build:centos-stream-9-x86_64[in_progress]
  • test (centos:stream9, 21)[in_progress]
  • centos-9-stream (centos:stream9, 13)[in_progress]
  • centos-9-stream (centos:stream9, 02)[in_progress]
  • test (centos:stream9, 12)[in_progress]
  • test (centos:stream9, 20)[in_progress]
  • test (centos:stream9, 01)[pending]
  • centos-9-stream (centos:stream9, 01)[queued]
  • test (centos:stream9, 11)[in_progress]
  • test (centos:stream9, 10)[pending]
  • centos-9-stream (centos:stream9, 10)[queued]
  • lint-c[in_progress]
  • lint-shell[in_progress]

🔴 Review - Missing review from a member (1 required)

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -s' found no issues.

@pvalena pvalena merged commit 45c50b5 into main Aug 8, 2025
32 of 78 checks passed
@pvalena
Copy link
Contributor Author

pvalena commented Aug 8, 2025

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants