Skip to content

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Aug 18, 2025

Author: Jo Zzsi [email protected]
Date: Wed Apr 23 19:21:59 2025 -0400

fix: load more kernel modules in sloppy hostonly mode

When hostonly_mode is set to "sloppy" instmods consults the host for currently loaded kernel modules and
refuses to copy the Linux kernel module into the generated initramfs unless the kernel
module is already loaded on the host.

Let's set hostonly explicitly to a better default before calling instmods.

For compatibility, we should not change the default in the instmods function itself.

(cherry picked from commit de862885ec55bb19bfa3e3f1afd27577b7c5e309)

Resolves: RHEL-94663

Author: Jo Zzsi <[email protected]>
Date:   Wed Apr 23 19:21:59 2025 -0400

    fix: load more kernel modules in sloppy hostonly mode

    When hostonly_mode is set to "sloppy" instmods consults the host for currently loaded kernel modules and
    refuses to copy the Linux kernel module into the generated initramfs unless the kernel
    module is already loaded on the host.

    Let's set hostonly explicitly to a better default before calling instmods.

    For compatibility, we should not change the default in the instmods function itself.

(cherry picked from commit de862885ec55bb19bfa3e3f1afd27577b7c5e309)

Resolves: RHEL-94663
@pvalena pvalena self-assigned this Aug 18, 2025
@github-actions github-actions bot changed the title fix(systemd): partial backport of (RHEL-94663) fix(systemd): partial backport of Aug 18, 2025
@github-actions
Copy link

Commit validation

Tracker - RHEL-94663

The following commits meet all requirements

commit upstream
43f9e72 - fix(systemd): partial backport of dracutdevs/dracut@de86288

Tracker validation

Success

🟢 Tracker RHEL-94663 has set desired product: rhel-9.7
🟢 Tracker RHEL-94663 has set desired component: dracut
🟢 Tracker RHEL-94663 has been approved
🟢 Tracker RHEL-94663 has set severity


Pull Request validation

Failed

🔴 Failed or pending checks:

  • test (centos:stream9, 30)[failure]
  • test (centos:stream9, 03)[failure]
  • test (centos:stream9, 36)[failure]
  • test (centos:stream9, 31)[failure]
  • test (centos:stream9, 35)[failure]
  • test (centos:stream9, 15)[failure]
  • test (centos:stream9, 14)[failure]
  • centos-9-stream (centos:stream9, 21)[cancelled]
  • centos-9-stream (centos:stream9, 02)[cancelled]
  • centos-9-stream (centos:stream9, 98)[cancelled]
  • centos-9-stream (centos:stream9, 17)[cancelled]
  • centos-9-stream (centos:stream9, 13)[cancelled]
  • centos-9-stream (centos:stream9, 11)[cancelled]
  • centos-9-stream (centos:stream9, 01)[cancelled]
  • centos-9-stream (centos:stream9, 40)[cancelled]
  • centos-9-stream (centos:stream9, 20)[cancelled]
  • centos-9-stream (centos:stream9, 41)[cancelled]
  • centos-9-stream (centos:stream9, 16)[cancelled]
  • centos-9-stream (centos:stream9, 12)[cancelled]
  • testing-farm:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-aarch64[in_progress]
  • test (centos:stream9, 02)[in_progress]
  • test (centos:stream9, 13)[in_progress]
  • test (centos:stream9, 41)[in_progress]
  • test (centos:stream9, 01)[in_progress]
  • test (centos:stream9, 11)[in_progress]
  • test (centos:stream9, 12)[in_progress]
  • test (centos:stream9, 16)[in_progress]
  • test (centos:stream9, 21)[in_progress]
  • test (centos:stream9, 20)[in_progress]
  • test (centos:stream9, 98)[in_progress]
  • test (centos:stream9, 17)[in_progress]
  • test (centos:stream9, 10)[pending]
  • centos-9-stream (centos:stream9, 10)[in_progress]
  • basic (centos:stream9, 04)[in_progress]
  • lint-c[in_progress]
  • lint-shell[in_progress]

🔴 Review - Missing review from a member (1 required)

@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -s' found no issues.

@pvalena
Copy link
Contributor Author

pvalena commented Aug 18, 2025

LGTM.

@pvalena pvalena merged commit f09dbb1 into main Aug 18, 2025
21 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants