Skip to content

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Sep 18, 2025

  • fix(multipath): disable user_friendly_names with mpathconf
  • chore: enhance backport_fix tool

bmarzins and others added 2 commits September 18, 2025 22:20
If dracut is creating /etc/multipath.conf by calling mpathconf in either
multipathd-configure.service or multipathd.sh, there is a chance that
the multipath config in the real root differs. Specifically, it might
have chosen different user_friendly_names for the devices. When the
systems switches to the real root, multipath may not be able to switch
the devices to their configured names because those might already be
in use. To avoid this, call mpathconf with "--user_friendly_names n"
to create a multipath.conf with user_friendly_names disabled. If all
devices use WWID names, it is always possible for multipath to rename
them later.

Fixes b8a92b7 ("multipath: add automatic configuration for multipath")

(cherry picked from commit f36f2869859eb5f9613a94a28dfaf31505e645cc)

Resolves: RHEL-91322
@github-actions
Copy link

Commit validation

Tracker - Missing issue tracker ✋

The following commits need an inspection

commit note
1f29099 - fix(multipath): disable user_friendly_names with mpathconf Missing upstream reference ‼️
9f65241 - chore: enhance backport_fix tool Missing issue tracker
Missing upstream reference ‼️

Tracker validation

🔴 Missing tracker or Unknown tracker type; type: 'unknown'


Pull Request validation

Failed

🔴 Failed or pending checks:

  • test (centos:stream9, 15)[failure]
  • test (centos:stream9, 36)[failure]
  • test (centos:stream9, 03)[failure]
  • test (centos:stream9, 14)[failure]
  • test (centos:stream9, 35)[failure]
  • test (centos:stream9, 30)[failure]
  • test (centos:stream9, 31)[failure]
  • centos-9-stream (centos:stream9, 40)[cancelled]
  • centos-9-stream (centos:stream9, 17)[cancelled]
  • centos-9-stream (centos:stream9, 13)[cancelled]
  • centos-9-stream (centos:stream9, 98)[cancelled]
  • centos-9-stream (centos:stream9, 01)[cancelled]
  • centos-9-stream (centos:stream9, 20)[cancelled]
  • centos-9-stream (centos:stream9, 21)[cancelled]
  • centos-9-stream (centos:stream9, 16)[cancelled]
  • centos-9-stream (centos:stream9, 12)[cancelled]
  • centos-9-stream (centos:stream9, 11)[cancelled]
  • centos-9-stream (centos:stream9, 41)[cancelled]
  • basic (centos:stream9, 04)[failure]
  • testing-farm:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-aarch64[in_progress]
  • test (centos:stream9, 20)[in_progress]
  • test (centos:stream9, 16)[in_progress]
  • test (centos:stream9, 40)[in_progress]
  • test (centos:stream9, 01)[in_progress]
  • test (centos:stream9, 17)[in_progress]
  • test (centos:stream9, 98)[in_progress]
  • test (centos:stream9, 11)[in_progress]
  • test (centos:stream9, 12)[in_progress]
  • test (centos:stream9, 10)[pending]
  • test (centos:stream9, 13)[in_progress]
  • test (centos:stream9, 21)[in_progress]
  • test (centos:stream9, 02)[pending]
  • centos-9-stream (centos:stream9, 10)[in_progress]
  • centos-9-stream (centos:stream9, 02)[in_progress]
  • lint-shell[in_progress]

🔴 Review - Missing review from a member (1 required)

@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/env zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -s' found no issues.

@pvalena
Copy link
Contributor Author

pvalena commented Sep 19, 2025

LGTM; errors on missing test dependencies like btrfs, dmraid, iscsi...

@pvalena pvalena merged commit d2f871e into main Sep 19, 2025
74 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants