Skip to content

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Sep 25, 2025

  • fix(pcsc): add opensc load module file
  • fix(pcsc): add --disable-polkit to pcscd.service
  • fix(pkcs11): delete trailing dot on libcryptsetup-token-systemd-pkcs11.so

On Fedora, and possibly others, this file loads opensc-pkcs11.so which you need to interact with the smart card to unlock a LUKS encrypted volume.

(cherry picked from commit e9baea97fb5dec6fb26ceaebb3e580bf272da2b8)

Resolves: RHEL-109631
Needs pcsc >= 2.0.0

polkit is not included in dracut and without this option, pcscd simply fails

(cherry picked from commit 57627c8d654986483d241b171114e01a725fae1e)

Resolves: RHEL-109631
@pvalena pvalena self-assigned this Sep 25, 2025
@github-actions github-actions bot changed the title rhel 9 fix 109631 (RHEL-109631) rhel 9 fix 109631 Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Commit validation

Tracker - RHEL-109631

The following commits meet all requirements

commit upstream
6c5a3de - fix(pkcs11): delete trailing dot on libcryptsetup-token-systemd-pkcs11… dracutdevs/dracut@1c762c0

The following commits need an inspection

commit note
95ba745 - fix(pcsc): add opensc load module file Missing upstream reference ‼️
6a907cc - fix(pcsc): add --disable-polkit to pcscd.service Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-109631 has set desired product: rhel-9.8
🟢 Tracker RHEL-109631 has set desired component: dracut
🟢 Tracker RHEL-109631 has been approved
🟢 Tracker RHEL-109631 has set severity


Pull Request validation

Failed

🔴 Failed or pending checks:

  • test (centos:stream9, 36)[failure]
  • test (centos:stream9, 35)[failure]
  • test (centos:stream9, 14)[failure]
  • test (centos:stream9, 31)[failure]
  • test (centos:stream9, 30)[failure]
  • test (centos:stream9, 15)[failure]
  • centos-9-stream (centos:stream9, 41)[cancelled]
  • centos-9-stream (centos:stream9, 21)[cancelled]
  • centos-9-stream (centos:stream9, 40)[cancelled]
  • centos-9-stream (centos:stream9, 16)[cancelled]
  • centos-9-stream (centos:stream9, 17)[cancelled]
  • centos-9-stream (centos:stream9, 20)[cancelled]
  • centos-9-stream (centos:stream9, 12)[cancelled]
  • centos-9-stream (centos:stream9, 10)[cancelled]
  • centos-9-stream (centos:stream9, 98)[cancelled]
  • centos-9-stream (centos:stream9, 13)[cancelled]
  • centos-9-stream (centos:stream9, 02)[cancelled]
  • centos-9-stream (centos:stream9, 11)[cancelled]
  • centos-9-stream (centos:stream9, 01)[cancelled]
  • testing-farm:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-aarch64[in_progress]
  • test (centos:stream9, 13)[in_progress]
  • test (centos:stream9, 16)[in_progress]
  • test (centos:stream9, 01)[in_progress]
  • test (centos:stream9, 20)[in_progress]
  • test (centos:stream9, 11)[in_progress]
  • test (centos:stream9, 41)[in_progress]
  • test (centos:stream9, 40)[in_progress]
  • test (centos:stream9, 17)[in_progress]
  • test (centos:stream9, 10)[in_progress]
  • test (centos:stream9, 12)[in_progress]
  • test (centos:stream9, 02)[in_progress]
  • test (centos:stream9, 98)[in_progress]
  • test (centos:stream9, 03)[in_progress]
  • test (centos:stream9, 21)[in_progress]
  • basic (centos:stream9, 04)[in_progress]
  • lint-shell[in_progress]

🔴 Review - Missing review from a member (1 required)

@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/env zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -s' found no issues.

…1.so

libcryptsetup-token-systemd-pkcs11.so.* doesn't match the file libcryptsetup-token-systemd-pkcs11.so

(cherry picked from commit 1c762c0da6ed2bb6fa44d5e0968605cc4d45361c)

Resolves: RHEL-109631
@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/env zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -s' found no issues.

@pvalena
Copy link
Contributor Author

pvalena commented Oct 3, 2025

LGTM; tested by 3rd party.

@pvalena pvalena merged commit 673232f into main Oct 3, 2025
22 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants