(RHEL-115032) Increment start limit counter only when we can start the unit #104
+97
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, e.g. requesting to start a unit that is under stopping may enter the failed state. This makes - rename .can_start() -> .test_startable(), and make it allow to return boolean and refuse to start units when it returns false, - refuse earlier to start units that are in the deactivating state, so several redundant conditions in .start() can be dropped, - move checks for unit states mapped to UNIT_ACTIVATING from .start() to .test_startable(). Fixes #39247. (cherry picked from commit 8eefd0f4debc0bcfeea89dd39c43e3318f3f7ae7) Resolves: RHEL-115032
As 'systemctl stop' is called with --no-block, previously systemd-resolved might not be stopped when 'resolvectl' is called, and the DBus connection might be closed during the call: ``` TEST-07-PID1.sh[5643]: + systemctl stop --no-block systemd-resolved.service TEST-07-PID1.sh[5643]: + resolvectl TEST-07-PID1.sh[5732]: Failed to get global data: Remote peer disconnected ``` Follow-up for 8eefd0f4debc0bcfeea89dd39c43e3318f3f7ae7. Fixes systemd/systemd#39388 (comment). (cherry picked from commit 6454fde83eef8da7391ad18a1b1a3248402f9214) Related: RHEL-115032
github-actions
bot
changed the title
Commit validationTracker - RHEL-115032 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-115032 has set desired product: Pull Request validationFailed🔴 Failed or pending checks:
🔴 Review - Missing review from a member (1 required) |
As the modified service requires about ~10 seconds for stopping, the service never hit the start limit even if we tried to restart the service more than 5 times. This also checks that the service is actually triggered by dbus method call. Follow-up for 8eefd0f4debc0bcfeea89dd39c43e3318f3f7ae7. (cherry picked from commit 44b4caad6cc99449bbf705350939fde1ed9b1248) Related: RHEL-115032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: RHEL-115032