(RHEL-118216) timer: don't run service immediately after restart of a timer #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit validationTracker - RHEL-118216 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-118216 has set desired product: Pull Request validationSuccess🟡 CI - Waived Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
And split the existing test into a separate subtest. (cherry picked from commit 953c347fb6f293acbd6da009646bfc071b68ddd7) Related: RHEL-118216
…rvice Provides coverage for: - systemd/systemd#31231 - systemd/systemd#35805 (cherry picked from commit 5730a400fd5ee82566fe03eb832121a0d4bc26b6) Related: RHEL-118216
When deserializing a serialized timer unit with RandomizedDelaySec= set, systemd should use the last inactive exit timestamp instead of current realtime to calculate the new next elapse, so the timer unit actually runs in the given calendar window. Provides coverage for: - systemd/systemd#18678 - systemd/systemd#27752 (cherry picked from commit f4c3c107d9be4e922a080fc292ed3889c4e0f4a5) Related: RHEL-118216
When a timer is restarted, don't reset the last_trigger field. This prevents the timer from triggering immediately. Fixes: #31231 (cherry picked from commit 3fc44a0f68412b649e16f12ff2f97a36c615457d) Resolves: RHEL-118216
Follow-up for 5730a400fd5ee82566fe03eb832121a0d4bc26b6. (cherry picked from commit 0cb252d50f35256bff569fa6213784f2d45ad6a1) Related: RHEL-118216
mrc0mmand
force-pushed
the
RHEL-118216-restarting-timers
branch
2 times, most recently
from
6993f37 to
ffe8e95
Compare
github-actions
bot
changed the title
Member
Author
|
The CI fails are unrelated (libasan errors), but I'll look into them soon. |
github-actions
bot
merged commit c2a0cd9
into
redhat-plumbers:main
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a timer is restarted, don't reset the last_trigger field.
This prevents the timer from triggering immediately.
Fixes: #31231
(cherry picked from commit 3fc44a0f68412b649e16f12ff2f97a36c615457d)
Resolves: RHEL-118216