Skip to content

(RHEL-113920) mkosi: install test dependencies for EnterNamespace= test #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
github-actions merged 3 commits into from
Nov 3, 2025
Merged

(RHEL-113920) mkosi: install test dependencies for EnterNamespace= test #95

github-actions merged 3 commits into from
Nov 3, 2025

Conversation

@mrc0mmand
Copy link
Member

@mrc0mmand mrc0mmand commented Oct 13, 2025 •
edited by github-actions bot
Loading

The test for the EnterNamespace= feature [0] has been both broken and
disabled since the migration to the mkosi framework, as it's missing the
libdw.pc file for pkg-config, so the test is skipped completely, and
it's also missing gcc to actually build the test binary.

[0] Part of TEST-87-AUX-UTILS-VM.coredump.sh

(cherry picked from commit 4d8e8d44ab3f6f99102faf0dcb53ca4de4d517ae)

Related: RHEL-113920

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Commit validation

Tracker - RHEL-113920

The following commits meet all requirements

commit upstream
b75e088 - test: build the crashing test binary outside of the test systemd/systemd@937f609
6e10795 - test: exclude test-stacktrace(-not)?-symbolized from the coredump chec… systemd/systemd@cfb604f
b6f709e - mkosi: install test dependencies for EnterNamespace= test systemd/systemd@4d8e8d4

Tracker validation

Success

🟢 Tracker RHEL-113920 has set desired product: rhel-10.2
🟢 Tracker RHEL-113920 has set desired component: systemd
🟢 Tracker RHEL-113920 has been approved
🟢 Tracker RHEL-113920 has set severity

Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@mrc0mmand mrc0mmand force-pushed the RHEL-113920-test-EnterNamespace-followups branch from cabf503 to 111ff1c Compare October 13, 2025 12:59
@github-actions github-actions bot changed the title mkosi: install test dependencies for EnterNamespace= test (RHEL-113920) mkosi: install test dependencies for EnterNamespace= test Oct 13, 2025
@mrc0mmand mrc0mmand marked this pull request as ready for review October 13, 2025 14:20
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Oct 13, 2025

The CI fail is unrelated (https://issues.redhat.com/browse/RHEL-119135).

@mrc0mmand mrc0mmand requested a review from msekletar October 13, 2025 14:34
@mrc0mmand mrc0mmand marked this pull request as draft October 14, 2025 08:10
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Oct 14, 2025

Moving to draft as we'll need #89 to land first, since it moves the coredump tests around.

@jamacku jamacku added this to the RHEL-10.2 milestone Oct 15, 2025
@mrc0mmand
test: build the crashing test binary outside of the test
b75e088 
So we don't have to pull in gcc and other stuff into it.

Also, make the test itself a bit more robust and debug-able.

(cherry picked from commit 937f609b41b9e27eba69c5ddbab4df2232e5a37b)

Related: RHEL-113920
@mrc0mmand
test: exclude test-stacktrace(-not)?-symbolized from the coredump check
6e10795 
As they are expected coredumps from the EnterNamespace= feature test.

(cherry picked from commit cfb604f8f7c83912648d69bd3ad89c2436b4b8ef)

Related: RHEL-113920
@mrc0mmand
mkosi: install test dependencies for EnterNamespace= test
b6f709e 
The test for the EnterNamespace= feature [0] has been both broken and
disabled since the migration to the mkosi framework, as it's missing the
libdw.pc file for pkg-config, so the test is skipped completely, and
it's also missing gcc to actually build the test binary.

[0] Part of TEST-87-AUX-UTILS-VM.coredump.sh

(cherry picked from commit 4d8e8d44ab3f6f99102faf0dcb53ca4de4d517ae)

Related: RHEL-113920
@mrc0mmand mrc0mmand force-pushed the RHEL-113920-test-EnterNamespace-followups branch from 111ff1c to a83abd8 Compare October 31, 2025 09:48
@mrc0mmand mrc0mmand force-pushed the RHEL-113920-test-EnterNamespace-followups branch from a83abd8 to b6f709e Compare October 31, 2025 11:05
@mrc0mmand mrc0mmand marked this pull request as ready for review October 31, 2025 11:59
@mrc0mmand
Copy link
Member Author

mrc0mmand commented Oct 31, 2025

(I intentionally omitted the last commit from the original PR, systemd/systemd@80b4cac, as it's not needed for RHEL/CentOS/Fedora systems)

@mrc0mmand
Copy link
Member Author

mrc0mmand commented Oct 31, 2025 •
edited
Loading

The CI fail is, yet again, unrelated (https://issues.redhat.com/browse/RHEL-119135).

dtardon
dtardon approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot merged commit bb285f7 into redhat-plumbers:main Nov 3, 2025
29 of 30 checks passed
@mrc0mmand mrc0mmand deleted the RHEL-113920-test-EnterNamespace-followups branch November 3, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtardon dtardon dtardon approved these changes

@msekletar msekletar Awaiting requested review from msekletar

Assignees

No one assigned

Labels

ci-waived released

Projects

None yet

Milestone

RHEL-10.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mrc0mmand @dtardon @jamacku