(RHEL-53112) Don't terminate sessions after cold (re)start of systemd-logind #99
+73
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People make weird assumptions around state preservation and expect logind to be stoppable. While this is realistically not OK we can probably improve things a little. This complements f01d8658a3a57d05a5156aefd32d8137c3ee3996 and adds support for deserializing the LEADER_PIDFDID= field. We still prioritize pidfd if got one from fdstore (as with service_notify_message_parse_new_pid() in pid1), but otherwise this should make logind restart more robust when fdstore gets spuriously cleared. Fixes #39437 (cherry picked from commit 45eea629e3b3a640bf6a5cd13f4c73c86b426b11) Resolves: RHEL-53112
(cherry picked from commit ebb730b96ded7674994235340c0d4a39af174f52) Related: RHEL-53112
Commit validationTracker - RHEL-53112 The following commits meet all requirements
Follow-up detectionFailed🔴 Some follow-up commits for this Pull Request were detected in upstream Follow-ups
Tracker validationSuccess🟢 Tracker RHEL-53112 has set desired product: Pull Request validationFailed🔴 Failed or pending checks:
🔴 Approval - missing or changes were requested Success🟢 Review - Reviewed by a member |
dtardon
requested changes
Nov 14, 2025
Member
dtardon
left a comment
dtardon
left a comment
There was a problem hiding this comment.
The follow-up is relevant. Please backport it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.