Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile to allow user to create output files not owned by root #128

Closed
wants to merge 1 commit into from

Conversation

pwright
Copy link

@pwright pwright commented Dec 12, 2017

The exister dockerfile creates output as root. This makes life difficult for ordinary users who run this this docker file to create html.
However, my proposal isn't ideal, it means that the user must allow nobody write access to the docs repo before running the container.
I'm happy to chmod a+rwx before running the container, but maybe others wouldn't want to do that.

The exister dockerfile creates output as root. This makes life difficult for ordinary users who run this this docker file to create html. 
However, my proposal isn't ideal, it means that the user must allow nobody write access to the docs repo before running the container. 
I'm happy to chmod a+rwx <repo> before running the container, but maybe others wouldn't want to do that.
@bexelbie
Copy link
Contributor

@finp I believe we should consider documenting around this. If you execute the container with this command, I believe you will find that your files are owned by your user:group:

docker run --rm -it -v pwd:/docs:z -u $(id -u):$(id -g) asciibinder

Would you be interested in helping document this? or modifying your PR to document it in file?

@pwright
Copy link
Author

pwright commented Dec 16, 2017

@bexelbie Yes, that makes sense, altho your syntax didn't work for me.
I've created a PR for this (as part of larger PR to get writer using asciibinder in minutes, without messing up ccutil). It's here
redhataccess/ascii_binder-docs#18
and this particular issue addressed here:
https://19-114003413-gh.circle-artifacts.com/0/home/circleci/docs/_preview/ascii_binder/latest/getting_started/building.html#building-using-docker

@bexelbie
Copy link
Contributor

@finp I'll look at the other PR as soon as I can. What is broken with the syntax? Are you on a non-Linux machine?

@pwright
Copy link
Author

pwright commented Dec 19, 2017

@bexelbie I'm on fedora (weird huh!)... I had to change the volume syntax to get it to work:
You: -v pwd:/docs:z
Me: -v ${PWD}:/docs:z

@bexelbie
Copy link
Contributor

doh! that'll teach me to type and not cut and paste. good catch @finp

@pwright
Copy link
Author

pwright commented Dec 29, 2017

closing in favor of redhataccess/ascii_binder-docs#18 (ie documentation change rather than dockerfile change)

@pwright pwright closed this Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants