Skip to content

eco_gotests: build container image #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredericlepied wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −18
Open

eco_gotests: build container image #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53aa0a3
eco_gotests: build container image
fredericlepied Nov 28, 2025
f5e5177
update GHA sha1
fredericlepied Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dci-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
steps:

- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
fetch-depth: 0 # Fetch all history to be able to look at the merge commits in dci-merge.sh

Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0

- name: Install dependent PRs if needed
uses: depends-on/depends-on-action@61cb3f4a0e2c8ae4b90c9448dc57c7ba9ca24c35 # main
uses: depends-on/depends-on-action@826c144163ac67bf08347590a5f81afd45da63ca # main
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
python-version: 3.11

Expand Down Expand Up @@ -95,18 +95,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
path: ${{ matrix.ansible }}/ansible_collections/redhatci/ocp

- name: Install dependent PRs if needed
uses: depends-on/depends-on-action@61cb3f4a0e2c8ae4b90c9448dc57c7ba9ca24c35 # main
uses: depends-on/depends-on-action@826c144163ac67bf08347590a5f81afd45da63ca # main
with:
token: ${{ secrets.GITHUB_TOKEN }}
path: ${{ matrix.ansible }}/ansible_collections/redhatci/ocp

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
python-version: 3.11

Expand All @@ -130,7 +130,7 @@ jobs:
steps:

- name: Check all dependent Pull Requests are merged
uses: depends-on/depends-on-action@61cb3f4a0e2c8ae4b90c9448dc57c7ba9ca24c35 # main
uses: depends-on/depends-on-action@826c144163ac67bf08347590a5f81afd45da63ca # main
with:
token: ${{ secrets.GITHUB_TOKEN }}
check-unmerged-pr: true
Expand All @@ -140,10 +140,10 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0

- name: Install dependent PRs if needed
uses: depends-on/depends-on-action@61cb3f4a0e2c8ae4b90c9448dc57c7ba9ca24c35 # main
uses: depends-on/depends-on-action@826c144163ac67bf08347590a5f81afd45da63ca # main
with:
token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preflight-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0

- name: Get Preflight latest release
id: preflight_latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0

- name: Add epoch from commit date as patch version in galaxy.yml
run: |
Expand Down
2 changes: 1 addition & 1 deletion hack/check_doc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# when run outside of a GitHub action
if [ -z "$GITHUB_STEP_SUMMARY" ]; then
GITHUB_STEP_SUMMARY=/dev/null
GITHUB_STEP_SUMMARY=/dev/stdout
fi

rc=0
Expand Down
4 changes: 2 additions & 2 deletions hack/check_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ if [ -z "$branch" ]; then
fi

REMOVED=$(git diff --diff-filter=D --name-only origin/main...$branch | grep -Eo '^roles/.+/' |
sed -Ee 's@(roles|defaults|templates|vars|scripts|handlers|tests|meta|tasks|files)/@@g' -e 's@/$@@' | uniq)
sed -Ee 's@/(defaults|templates|vars|scripts|handlers|tests|meta|tasks|files)/@/@g' -e 's@/$@@' -e 's@^roles/@@' | uniq)

ADDED=$(git diff --diff-filter=A --name-only origin/main...$branch | grep -Eo '^roles/.+/' |
sed -Ee 's@(roles|defaults|templates|vars|scripts|handlers|tests|meta|tasks|files)/@@g' -e 's@/$@@' | uniq)
sed -Ee 's@/(defaults|templates|vars|scripts|handlers|tests|meta|tasks|files)/@/@g' -e 's@/$@@' -e 's@^roles/@@' | uniq)

# check if the roles are fully removed
if [ -n "$REMOVED" ]; then
Expand Down
7 changes: 4 additions & 3 deletions roles/eco_gotests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# eco_gotests

This role runs eco-gotests for OpenShift CNF (Cloud Native Functions) testing, specifically for PTP (Precision Time Protocol) and SRIOV (Single Root I/O Virtualization) test suites.
This role runs [eco-gotests](https://github.com/rh-ecosystem-edge/eco-gotests) for OpenShift CNF (Cloud Native Functions) testing, specifically for PTP (Precision Time Protocol) and SRIOV (Single Root I/O Virtualization) test suites.

## Requirements

Expand All @@ -9,7 +9,8 @@ This role runs eco-gotests for OpenShift CNF (Cloud Native Functions) testing, s
- Valid kubeconfig for the OpenShift cluster

### PTP requirements
- ptp-operator have to be installed

- The ptp-operator has to be installed
- Need apiVersion set to 2 on PtpOperatorConfig

## Role Variables
Expand All @@ -25,6 +26,7 @@ This role runs eco-gotests for OpenShift CNF (Cloud Native Functions) testing, s

#### General Configuration
- `eco_gotests_image` (default: `"quay.io/ocp-edge-qe/eco-gotests:latest"`): Container image for eco-gotests
- `eco_gotests_path` (default: undefined): path where to find the source code to build the container. If this is specified, the `eco_gotests_image` is ignored.

#### SRIOV Test Configuration
- `eco_gotests_sriov_labels` (default: `"sriov-hw-enabled"`): Test labels for SRIOV tests
Expand All @@ -39,7 +41,6 @@ This role runs eco-gotests for OpenShift CNF (Cloud Native Functions) testing, s
- `eco_gotests_test_verbose` (default: `true`): Enable verbose test output
- `eco_gotests_dump_failed_tests` (default: `true`): Dump failed test information


## Example Playbook

```yaml
Expand Down
12 changes: 12 additions & 0 deletions roles/eco_gotests/tasks/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---

- name: "Build the eco-gotests image"
ansible.builtin.command:
cmd: "make build-docker-image"
chdir: "{{ eco_gotests_path }}"

- name: "Overwrite image name"
ansible.builtin.set_fact:
eco_gotests_image: "eco-gotests:latest"

...
5 changes: 5 additions & 0 deletions roles/eco_gotests/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
mode: '0755'
loop: "{{ eco_gotests_test_suites | list }}"

- name: "Build container image"
ansible.builtin.include_tasks: build.yml
when:
- 'eco_gotests_path is defined'

- name: "Eco_gotests : Run PTP tests"
ansible.builtin.include_tasks: ptp.yml
when:
Expand Down