Only set SSL parameter if it's not explicitly set #280
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-fix-issue-279
branch
5 times, most recently
from
0ae2399 to
2312db7
Compare
IevaGraz
approved these changes
Jan 8, 2026
Contributor
Author
|
This is still not right... |
PR redis-rb#277 fixed the issue where `ssl` was not set on the Redis client automatically if a `rediss://` URl were used: ```ruby require 'redis' config = { url: 'rediss://mymaster', sentinels: [ { host: 'localhost', port: 26379, ssl: true } , { host: 'localhost', port: 26381, ssl: true }, { host: 'localhost', port: 26380, ssl: true } ] } client = Redis.new(config) ```` However, it broke the case if you explicitly set `ssl` and expected it to propagate: ```ruby require 'redis' config = { name: 'mymaster', ssl: true, sentinels: [ { host: 'localhost', port: 26379 }, { host: 'localhost', port: 26381 }, { host: 'localhost', port: 26380 } ] } client = Redis.new(config) ```` Closes redis-rb#279
stanhu
force-pushed
the
sh-fix-issue-279
branch
from
2312db7 to
8d61c2c
Compare
stanhu
changed the title
IevaGraz
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #277 fixed the issue where
sslwas not set on the Redis client automatically if arediss://URL were used:However, it broke the case if you explicitly set
ssland expected for it to propagate:Closes #279