Support the KNN shard-ratio feature#494
Open
mgravell wants to merge 6 commits into
Open
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a2898de. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

from 8.6.1,
FT.HYBRID KNNhas a newSHARD_K_RATIOfeature: RediSearch/RediSearch#8227Note
Medium Risk
Adds a new KNN query parameter and adjusts public API signatures/argument serialization; incorrect token counting or version gating could break hybrid search queries against Redis servers that don’t support the option.
Overview
Adds support for RedisSearch 8.6.1+ KNN
SHARD_K_RATIOby extendingVectorSearchMethod.NearestNeighbourwith an optionalshardRatiothat serializes toSHARD_K_RATIOand updates KNN token counting.Updates the public API surface (keeps a binary-compat overload), expands unit/integration tests with new shard-ratio scenarios, and enhances test skip/version logic to allow deferring xUnit skip evaluation and optionally overriding the minimum Redis version per scenario. Also updates the Docker test image default to a custom 8.8 build.
Reviewed by Cursor Bugbot for commit a2898de. Bugbot is set up for automated code reviews on this repo. Configure here.