feat(options): add DialerRetries and DialerRetryTimeout to ClusterOpions, RingOptions, and FailoverOptions #3686
+101
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions, RingOptions, and FailoverOptions Add DialerRetries and DialerRetryTimeout fields to ClusterOptions, RingOptions, and FailoverOptions to allow users to configure connection retry behavior for cluster, ring, and sentinel clients. These options were previously only available for the standard Client and were added to connection pools in redis#3518. This change ensures feature parity across all client types. Changes: - Add DialerRetries and DialerRetryTimeout fields to ClusterOptions - Add DialerRetries and DialerRetryTimeout fields to RingOptions - Add DialerRetries and DialerRetryTimeout fields to FailoverOptions - Update clientOptions() methods to pass through these values - Update sentinelOptions() method to pass through these values - Add tests to verify correct pass-through behavior Fixes issue where ClusterClient, Ring, and FailoverClient users could not customize connection retry behavior and were stuck with defaults (5 retries, 100ms backoff).
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Member
|
@naveenchander30 thank you for this contribution! Looks good on a first quick pass, will do a final review over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DialerRetries and DialerRetryTimeout fields to ClusterOptions, RingOptions, and FailoverOptions to allow users to configure connection retry behavior for cluster, ring, and sentinel clients.
These options were previously only available for the standard Client and were added to connection pools in #3518. This change ensures feature parity across all client types.
Changes:
Fixes issue where ClusterClient, Ring, and FailoverClient users could not customize connection retry behavior and were stuck with defaults (5 retries, 100ms backoff).