Add maintainer review skill - #3924
Open
ofekshenawa wants to merge 3 commits into
Open
Conversation
Update the 8.10 mapping in both CI redis_version_mapping arrays from the transient custom build to 8.10-rc2, and promote 8.10-rc2 to the local-dev default (Makefile, docker-compose, doctests) with REDIS_VERSION=8.10.
Member
|
Checked the file paths and command references against the repo — all accurate. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only changes under
.claude/andAGENTS.md; no client library or runtime behavior is modified.Overview
Adds a
maintainer-reviewClaude skill so agents can triage go-redis GitHub issues and PRs like maintainers: validate claims, gate on demonstrated need vs existing APIs, compare competing PRs, and output staged decisions plus copy-paste maintainer comments (not line-by-line code review).The main
SKILL.mddefines a seven-step workflow—read-only remote inspection, unmet-need and design challenges, competing-PR discovery, desk review vs approval-gated Docker/make testprobes, merge-worthiness labels, and reporting rules tied to go-redis specifics (client variants,ConnState/pool ownership, custom-vetsetval, released-command policy).references/evaluation-framework.mdholds severity rubrics, evidence checks, concurrency interleaving matrices, comment templates, and compact report formats for issues, PRs, and competing PRs.AGENTS.mdlistsmaintainer-reviewalongside the other.claude/skills/playbooks.Reviewed by Cursor Bugbot for commit 23af418. Bugbot is set up for automated code reviews on this repo. Configure here.