feat(options): optionally allow custom logger to be provided#1851
Open
iainsproat wants to merge 1 commit intoredis:mainfrom
Open
feat(options): optionally allow custom logger to be provided#1851iainsproat wants to merge 1 commit intoredis:mainfrom
iainsproat wants to merge 1 commit intoredis:mainfrom
Conversation
|
Why isn't this merged yet? |
|
Exactly what was missing in ioredis, the ability to have a custom logger. Please, I hope you can merge this quickly, it's been several months already 😅 It's exactly what I need right now. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically closed due to inactivity. |
Author
|
There was no reason for closing this afaik, the problem and PR is still relevant. A maintainer will have to re-open this as I don't have permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many environments logging to console is not recommended, and instead a different logging mechanism is used. This may be to provide metadata, or to ensure the logged message conforms to a particular format (e.g. json), etc..
This Pull Request allows a different logging mechanism to optionally be provided. The logging mechanism must conform to the existing interface expected of
console; e.g. it must provide anerror,warn, andlogmethod.Defaults to
console, which is the existing behaviour.