chore(release): stop overwriting npm latest dist-tag#1977
Merged
nkaradzhov merged 1 commit intoredis:v4from Aug 4, 2025
Merged
chore(release): stop overwriting npm latest dist-tag#1977nkaradzhov merged 1 commit intoredis:v4from
latest dist-tag#1977nkaradzhov merged 1 commit intoredis:v4from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the npm release process by ensuring the v4 branch is assigned its own dist-tag and its releases are restricted to the 4.x version range, preventing them from overwriting the npm latest tag.
- Removed the explicit branch filter from the semantic-release command
- Updates the release workflow to potentially rely on a separate branch configuration for v4
Files not reviewed (1)
- .releaserc.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:31
- The removal of the '--branches v4' flag may cause v4 maintenance releases to be merged with the default release channel. Consider verifying that the semantic-release configuration properly restricts the v4 branch to the 4.x version range, for instance via a configuration file.
run: npx semantic-release
Assigns the v4 branch its own dist-tag (`v4`) and restricts it to the 4.x version range. This prevents v4 maintenance releases from overwriting the latest major version in the default npm channel.
nkaradzhov
changed the title
latest dist-taglatest dist-tag
elena-kolevska
approved these changes
May 20, 2025
Contributor
|
@nkaradzhov should we merge this PR? |
|
🎉 This PR is included in version 4.30.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigns the v4 branch its own dist-tag (
v4) and restricts it to the 4.x version range. This prevents v4 maintenance releases from overwriting the latest major version in the default npm channel.#1974