[automatic failover] Record failures for each attempt of write on channel including retries #3583
+1,564
−501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new channel handler and extract command tracking logic and add Netty pipeline handler
Summary
This PR refactors the failover module to separate command tracking concerns and introduces a Netty pipeline handler for comprehensive command result tracking.
Changes
1. New
DatabaseCommandTrackerclassDatabaseEndpointImplandDatabasePubSubEndpointImplCommandWriterinterface for delegation patternonComplete()callbacks2. New
MultiDbOutboundAdapterNetty handlerDatabaseCommandTrackerfor comprehensive result trackingCommandHandlerin the pipeline3. Refactored
DatabaseEndpointImplandDatabasePubSubEndpointImplDatabaseCommandTrackerCommandWriterinterfacenotifyChannelActive/notifyChannelInactive)Architecture
The new architecture splits command result tracking into two layers:
DatabaseCommandTracker (callback-based):
onComplete()callbacksMultiDbOutboundAdapter (pipeline-based):
Tests
DatabaseCommandTrackerUnitTests(527 lines) - comprehensive unit testsMultiDbOutboundAdapterUnitTests(309 lines) - unit tests for pipeline handlerDatabasePubSubEndpointTrackerTests(310 lines) - PubSub-specific testsDatabaseEndpointCallbackTests- refactored to focus on integration behavior and avoid duplicationAll tests passing: 44 unit tests covering the new architecture
Benefits