Update NIO event loop creation to use Netty 4.2 API #3584 #3585
Conversation
After upgrading to Netty 4.2 in #3405, the NIO event loop creation in DefaultEventLoopGroupProvider still used the old Netty 4.1 API (new NioEventLoopGroup()), which creates event loops incompatible with applications using Netty 4.2's new IO model. This commit introduces NioProvider following the same pattern as EpollProvider, KqueueProvider, and IOUringProvider. The provider creates NIO event loop groups using MultiThreadIoEventLoopGroup with NioIoHandler.newFactory(), ensuring compatibility with Netty 4.2. Fixes #3584
The test was expecting NioEventLoopGroup but now we return MultiThreadIoEventLoopGroup (Netty 4.2 API). Updated the test to use EventLoopGroup interface instead of the concrete type.
|
Fixed the test failure. The issue was that The fix is backward compatible - the test still requests |
…3584 Updated tests to use MultithreadEventLoopGroup instead of NioEventLoopGroup for variables that need to call executorCount(). The allocate() method now returns MultiThreadIoEventLoopGroup (Netty 4.2 API) instead of NioEventLoopGroup.
|
Fixed another test file ( |
|
✅ All CI checks are now passing! The PR is ready for review. Summary of changes:
This ensures Lettuce is fully compatible with Netty 4.2's new IO model and eliminates the |
Description
This PR fixes the incomplete Netty 4.2 migration for NIO event loop creation.
After upgrading to Netty 4.2 in #3405, the NIO event loop creation in
DefaultEventLoopGroupProviderstill used the old Netty 4.1 API (new NioEventLoopGroup()), which creates event loops incompatible with applications using Netty 4.2's new IO model.Changes
NioProvider: Following the same pattern asEpollProvider,KqueueProvider, andIOUringProviderDefaultEventLoopGroupProvider: Now usesNioProvider.getResources()to create NIO event loop groupsMultiThreadIoEventLoopGroupwithNioIoHandler.newFactory()Impact
This ensures that NIO event loop creation is consistent with the other transports and compatible with Netty 4.2's new IO model. Applications using Netty 4.2 event loops will no longer encounter
IllegalStateException: incompatible event loop typeerrors when using Lettuce.Testing
Fixes #3584