shard_connection: Support abstract Unix socket clients#257
Open
LINKIWI wants to merge 1 commit intoredis:masterfrom
Open
shard_connection: Support abstract Unix socket clients#257LINKIWI wants to merge 1 commit intoredis:masterfrom
LINKIWI wants to merge 1 commit intoredis:masterfrom
Conversation
cd61c5f to
862e5cc
Compare
Author
|
@filipecosta90 This is still a patch we are interested in. Could you help review this? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for
--unix-socketto accept an abstract Unix socket when the socket name prefixed with@.Motivation: I am orchestrating execution of the
memtier_benchmarkbinary against Redis protocol-compliant servers in an environment where the filesystem is not writable and binding TCP listeners is not preferred. Abstract Unix sockets are a convenient solution for this scenario.Verification
Preparation
Unix socket file
$ netstat -ax | grep redis unix 2 [ ACC ] STREAM LISTENING 223273 /tmp/redis.sockAbstract Unix socket
$ netstat -ax | grep redis unix 2 [ ACC ] STREAM LISTENING 239347 @redis.sock