Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4195: add TCEs to the range query page #2831

Closed
wants to merge 3 commits into from
Closed

DOC-4195: add TCEs to the range query page #2831

wants to merge 3 commits into from

Conversation

dwdougherty
Copy link

Description

Tabbed code examples (TCEs) for the exact match query page. Please merge as soon as possible.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@dwdougherty dwdougherty changed the title DOC-4194: add TCEs to the range query page DOC-4195: add TCEs to the range query page Sep 10, 2024
@sjpotter
Copy link
Contributor

@dwdougherty is it a problem that the test is failing?

@dwdougherty
Copy link
Author

How is it failing? I runs successfully on my system.

@sjpotter
Copy link
Contributor

github test "doctests" in the github actions ."all checks have failed"

@dwdougherty
Copy link
Author

That's because the data file isn't in the branch (it was committed as part of another branch). When all the PRs are merged, it should be just fine.

@sjpotter
Copy link
Contributor

so I comitted the first one, but still failing as query_em.json doesn't exist?

@sjpotter
Copy link
Contributor

ok, merged in the initial pr into all of these PRs, helps me make progress.

@sjpotter
Copy link
Contributor

@leibale looks fine to me, is there anything I'm not understanding that would be an issue?

@dwdougherty dwdougherty closed this by deleting the head repository Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants