Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(in progress) Attempting to simplify and cleanup code. #241

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

slice4e
Copy link
Collaborator

@slice4e slice4e commented Jun 23, 2023

Filipe,

I wanted to simplify the code a bit. Lets discuss this next time?
Some functions were way too long and hard to efficiently follow.
I made main() and blocking_read() much more manageable. And I would like to do a bit more in the same direction with the rest of the code if you agree.
Long term, after simplifying enough, ideally I think we should get rid of the stand_alone_runner and just have an option for the self_contained_coordinator to do that. Currently they are just sharing 80% of the code ...

Lets discuss it.

@slice4e slice4e marked this pull request as draft June 29, 2023 18:10
@slice4e slice4e closed this Jun 29, 2023
@slice4e slice4e deleted the beautify branch June 29, 2023 18:10
@slice4e slice4e restored the beautify branch June 29, 2023 18:12
@slice4e slice4e deleted the beautify branch June 29, 2023 18:13
@slice4e slice4e restored the beautify branch June 29, 2023 18:14
@slice4e slice4e reopened this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant