Fix protocol version checking (#2737)

redis · May 4, 2023 · 49ed60b · 49ed60b
1 parent f1aa582
commit 49ed60b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/redis/asyncio/client.py b/redis/asyncio/client.py
@@ -255,7 +255,7 @@ def __init__(
 
         self.response_callbacks = CaseInsensitiveDict(self.__class__.RESPONSE_CALLBACKS)
 
-        if self.connection_pool.connection_kwargs.get("protocol") == "3":
+        if self.connection_pool.connection_kwargs.get("protocol") in ["3", 3]:
             self.response_callbacks.update(self.__class__.RESP3_RESPONSE_CALLBACKS)
 
         # If using a single connection client, we need to lock creation-of and use-of

diff --git a/redis/client.py b/redis/client.py
@@ -1109,7 +1109,7 @@ def __init__(
 
         self.response_callbacks = CaseInsensitiveDict(self.__class__.RESPONSE_CALLBACKS)
 
-        if self.connection_pool.connection_kwargs.get("protocol") == "3":
+        if self.connection_pool.connection_kwargs.get("protocol") in ["3", 3]:
             self.response_callbacks.update(self.__class__.RESP3_RESPONSE_CALLBACKS)
 
     def __repr__(self):

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -479,4 +479,4 @@ def is_resp2_connection(r):
         protocol = r.connection_pool.connection_kwargs.get("protocol")
     elif isinstance(r, redis.RedisCluster):
         protocol = r.nodes_manager.connection_kwargs.get("protocol")
-    return protocol == "2" or protocol is None
+    return protocol in ["2", 2, None]