Add dynamic_startup_nodes parameter to async RedisCluster #3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kakadus
force-pushed
the
add-dynamic-startup-nodes-flag-to-async-redis-cluster
branch
from
c9ca010 to
cce34d7
Compare
Kakadus
force-pushed
the
add-dynamic-startup-nodes-flag-to-async-redis-cluster
branch
from
cce34d7 to
dd2ee3f
Compare
|
any news here? this looks good to me |
5 tasks
|
Hi @Kakadus would you have some time to complete this PR. There are some conflicts with the master branch that need to be resolved. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the "dynamic_startup_nodes" parameter to the async RedisCluster, aligning its behavior with the sync version.
- Introduces a new parameter to enable or disable dynamic DNS resolution for startup nodes.
- Implements handling in both the NodesManager and RedisCluster initialization.
- Adds parameterized tests to verify behavior with both True and False values.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_asyncio/test_cluster.py | Adds tests for dynamic startup nodes behavior using parameterized inputs |
| redis/asyncio/cluster.py | Updates RedisCluster and NodesManager to support the new dynamic_startup_nodes parameter |
| CHANGES | Documents the addition of the dynamic_startup_nodes parameter |
| ] | ||
| startup_nodes = list(rc.nodes_manager.startup_nodes.keys()) | ||
| if dynamic_startup_nodes is True: | ||
| assert startup_nodes.sort() == discovered_nodes.sort() |
There was a problem hiding this comment.
Using list.sort() returns None; please use sorted(startup_nodes) and sorted(discovered_nodes) to correctly compare the lists.
Suggested change
| assert startup_nodes.sort() == discovered_nodes.sort() | |
| assert sorted(startup_nodes) == sorted(discovered_nodes) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
The async version of the RedisCluster lacked the
dynamic_startup_nodesparameter. This PR adds the parameter to be activated when dynamic DNS endpoints for startup nodes are in use.Enabling
dynamic_startup_nodesfixes #2472, which describes the problem in detail.#3111 also addresses said issue, but their logic is different to the sync version, while this approach moves the behaviour of the async version closer to the sync version.