feat: Hide InitAddress when connecting to a redis cluster using NewClient() #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknowntpo
force-pushed
the
feat-hide-initAddr
branch
from
062dd1c to
e07440a
Compare
unknowntpo
changed the title
rueian
reviewed
Dec 7, 2024
cluster.go
Outdated
| nodes = append(nodes, addr) | ||
| for addr, role := range c.conns { | ||
| // only display non-hidden connrole | ||
| if !role.hidden { |
Collaborator
There was a problem hiding this comment.
We don't need to change this nodes() method. It is a private method for other testing purposes.
We should test this new hidden behaivor explicitly in a new test case for the public Node() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #635
What's changed:
In
(c *clusterClient) _refresh(), when values inClientOption.InitAddressis not in the return value ofgetClusterSlots, it should be hidden.