Skip to content

Umm/develop/274 observation bug - #40

Merged
janoliver20 merged 3 commits into
developfrom
umm/develop/274-observation-bug
Feb 27, 2026
Merged

Umm/develop/274 observation bug#40
janoliver20 merged 3 commits into
developfrom
umm/develop/274-observation-bug

Conversation

@janoliver20

Copy link
Copy Markdown
image

# Conflicts:
#	studymanager-services/src/main/java/io/redlink/more/studymanager/scheduling/UpsertOccurredObservationsCron.java
@janoliver20
janoliver20 requested a review from westei February 27, 2026 09:52
@janoliver20 janoliver20 self-assigned this Feb 27, 2026
@github-actions

Copy link
Copy Markdown

Test Results

149 tests  ±0   148 ✅ ±0   1m 38s ⏱️ -16s
 50 suites ±0     1 💤 ±0 
 50 files   ±0     0 ❌ ±0 

Results for commit 2e1420d. ± Comparison against base commit 96f9d0c.

@iaigner iaigner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janoliver20
janoliver20 merged commit 9cd60a4 into develop Feb 27, 2026
5 checks passed

public class Measurement {
public enum Type {
INTEGER, DOUBLE, LONG, STRING, BOOLEAN, DATE, OBJECT, STRING_ARRAY

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde gerne das Measurement umbauen, dass es dort ARRAY oder SINGLE_VALUE gibt. Würde da auch gerne eine REQUIRED oder OPTIONAL haben. Dann könnte die Data Health noch besser checken ob die Werte OK sind, ohne Custom Implementations durch die Observations .. aber das ist ein anderer Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants